Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 2422993005: MD Settings: Migrate startup URL action menu to settings-action-menu. (Closed)

Created:
4 years, 2 months ago by dpapad
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, vitalyp+closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Migrate startup URL action menu to settings-action-menu. BUG=639718 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a9caf0ba2aa56d28d432941d0e061f7aa5f38d2f Cr-Commit-Position: refs/heads/master@{#425859}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit. #

Patch Set 3 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M chrome/browser/resources/settings/on_startup_page/compiled_resources2.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_url_entry.html View 2 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_url_entry.js View 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/test/data/webui/settings/startup_urls_page_test.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
dpapad
4 years, 2 months ago (2016-10-17 21:04:34 UTC) #5
Dan Beam
lgtm https://codereview.chromium.org/2422993005/diff/1/chrome/browser/resources/settings/on_startup_page/compiled_resources2.gyp File chrome/browser/resources/settings/on_startup_page/compiled_resources2.gyp (right): https://codereview.chromium.org/2422993005/diff/1/chrome/browser/resources/settings/on_startup_page/compiled_resources2.gyp#newcode34 chrome/browser/resources/settings/on_startup_page/compiled_resources2.gyp:34: '../compiled_resources2.gyp:settings_action_menu', lazy render?
4 years, 2 months ago (2016-10-17 22:59:49 UTC) #8
dpapad
https://codereview.chromium.org/2422993005/diff/1/chrome/browser/resources/settings/on_startup_page/compiled_resources2.gyp File chrome/browser/resources/settings/on_startup_page/compiled_resources2.gyp (right): https://codereview.chromium.org/2422993005/diff/1/chrome/browser/resources/settings/on_startup_page/compiled_resources2.gyp#newcode34 chrome/browser/resources/settings/on_startup_page/compiled_resources2.gyp:34: '../compiled_resources2.gyp:settings_action_menu', On 2016/10/17 at 22:59:49, Dan Beam wrote: > ...
4 years, 2 months ago (2016-10-17 23:08:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422993005/40001
4 years, 2 months ago (2016-10-17 23:20:18 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-18 02:20:24 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 02:22:41 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a9caf0ba2aa56d28d432941d0e061f7aa5f38d2f
Cr-Commit-Position: refs/heads/master@{#425859}

Powered by Google App Engine
This is Rietveld 408576698