Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6854)

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_url_entry.html

Issue 2422993005: MD Settings: Migrate startup URL action menu to settings-action-menu. (Closed)
Patch Set: Nit. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
diff --git a/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html b/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
index c99283d3501ffcfbe8f47aba8ef0bf5d2765aa31..fac9bc8d349f8ab9d9ba0f066fab083afd57c2a9 100644
--- a/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
+++ b/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
@@ -1,9 +1,10 @@
+<link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_render.html">
<link rel="import" href="chrome://resources/cr_elements/icons.html">
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/html/icon.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-dropdown.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
<link rel="import" href="/on_startup_page/startup_urls_page_browser_proxy.html">
+<link rel="import" href="/settings_action_menu.html">
<link rel="import" href="/settings_shared_css.html">
<dom-module id="settings-startup-url-entry">
@@ -21,22 +22,19 @@
<div class="text-elide">[[model.title]]</div>
<div class="text-elide secondary">[[model.url]]</div>
</div>
- <paper-icon-button id="dots" icon="cr:more-vert" toggles
- active="{{menuOpened}}" tabindex$="[[tabindex]]">
+ <paper-icon-button id="dots" icon="cr:more-vert" tabindex$="[[tabindex]]"
+ on-tap="onDotsTap_">
</paper-icon-button>
- <template is="dom-if" if="[[menuOpened]]">
- <iron-dropdown vertical-align="auto" horizontal-align="right"
- opened="{{menuOpened}}">
- <div class="dropdown-content">
- <button class="dropdown-item" role="option" on-tap="onEditTap_">
- $i18n{onStartupEdit}
- </button>
- <button class="dropdown-item" role="option" id="remove"
- on-tap="onRemoveTap_">
- $i18n{onStartupRemove}
- </button>
- </div>
- </iron-dropdown>
+ <template is="cr-lazy-render" id="menu">
+ <dialog is="settings-action-menu">
+ <button class="dropdown-item" role="option" on-tap="onEditTap_">
+ $i18n{onStartupEdit}
+ </button>
+ <button class="dropdown-item" role="option" id="remove"
+ on-tap="onRemoveTap_">
+ $i18n{onStartupRemove}
+ </button>
+ </dialog>
</template>
</div>
</template>

Powered by Google App Engine
This is Rietveld 408576698