Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2422843003: Remove usage of FOR_EACH_OBSERVER macro in google_apis (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in google_apis Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/3227eb557cf28256df2764c6149d0178ea9d17c7 Cr-Commit-Position: refs/heads/master@{#425758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -61 lines) Patch
M google_apis/drive/auth_service.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M google_apis/gaia/account_tracker.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M google_apis/gaia/identity_provider.cc View 1 chunk +10 lines, -11 lines 0 comments Download
M google_apis/gaia/oauth2_token_service.cc View 7 chunks +25 lines, -28 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_delegate.cc View 3 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 13:13:01 UTC) #6
Roger Tawa OOO till Jul 10th
lgtm
4 years, 2 months ago (2016-10-17 16:59:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422843003/1
4 years, 2 months ago (2016-10-17 18:45:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 19:55:02 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 19:57:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3227eb557cf28256df2764c6149d0178ea9d17c7
Cr-Commit-Position: refs/heads/master@{#425758}

Powered by Google App Engine
This is Rietveld 408576698