Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: google_apis/gaia/oauth2_token_service_delegate.cc

Issue 2422843003: Remove usage of FOR_EACH_OBSERVER macro in google_apis (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/gaia/oauth2_token_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gaia/oauth2_token_service_delegate.cc
diff --git a/google_apis/gaia/oauth2_token_service_delegate.cc b/google_apis/gaia/oauth2_token_service_delegate.cc
index 0898c7a23e70490b19355ba7a26f57f638dcfea7..ccdba7810ce7158d47979e981e6e78444b0e3783 100644
--- a/google_apis/gaia/oauth2_token_service_delegate.cc
+++ b/google_apis/gaia/oauth2_token_service_delegate.cc
@@ -58,17 +58,19 @@ bool OAuth2TokenServiceDelegate::IsError(const GoogleServiceAuthError& error) {
void OAuth2TokenServiceDelegate::StartBatchChanges() {
++batch_change_depth_;
- if (batch_change_depth_ == 1)
- FOR_EACH_OBSERVER(OAuth2TokenService::Observer, observer_list_,
- OnStartBatchChanges());
+ if (batch_change_depth_ == 1) {
+ for (auto& observer : observer_list_)
+ observer.OnStartBatchChanges();
+ }
}
void OAuth2TokenServiceDelegate::EndBatchChanges() {
--batch_change_depth_;
DCHECK_LE(0, batch_change_depth_);
- if (batch_change_depth_ == 0)
- FOR_EACH_OBSERVER(OAuth2TokenService::Observer, observer_list_,
- OnEndBatchChanges());
+ if (batch_change_depth_ == 0) {
+ for (auto& observer : observer_list_)
+ observer.OnEndBatchChanges();
+ }
}
void OAuth2TokenServiceDelegate::FireRefreshTokenAvailable(
@@ -79,14 +81,14 @@ void OAuth2TokenServiceDelegate::FireRefreshTokenAvailable(
FROM_HERE_WITH_EXPLICIT_FUNCTION(
"422460 OAuth2TokenService::FireRefreshTokenAvailable"));
- FOR_EACH_OBSERVER(OAuth2TokenService::Observer, observer_list_,
- OnRefreshTokenAvailable(account_id));
+ for (auto& observer : observer_list_)
+ observer.OnRefreshTokenAvailable(account_id);
}
void OAuth2TokenServiceDelegate::FireRefreshTokenRevoked(
const std::string& account_id) {
- FOR_EACH_OBSERVER(OAuth2TokenService::Observer, observer_list_,
- OnRefreshTokenRevoked(account_id));
+ for (auto& observer : observer_list_)
+ observer.OnRefreshTokenRevoked(account_id);
}
void OAuth2TokenServiceDelegate::FireRefreshTokensLoaded() {
@@ -96,8 +98,8 @@ void OAuth2TokenServiceDelegate::FireRefreshTokensLoaded() {
FROM_HERE_WITH_EXPLICIT_FUNCTION(
"422460 OAuth2TokenService::FireRefreshTokensLoaded"));
- FOR_EACH_OBSERVER(OAuth2TokenService::Observer, observer_list_,
- OnRefreshTokensLoaded());
+ for (auto& observer : observer_list_)
+ observer.OnRefreshTokensLoaded();
}
net::URLRequestContextGetter* OAuth2TokenServiceDelegate::GetRequestContext()
« no previous file with comments | « google_apis/gaia/oauth2_token_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698