Upstream ShouldOverrideUrlLoading changes

android_webview/common/render_view_messages.h

Index: android_webview/common/render_view_messages.h
diff --git a/android_webview/common/render_view_messages.h b/android_webview/common/render_view_messages.h
index 47c85d7ff0f6af0fa0cf01485565e858a7aad561..7a8d73807efca11101c61cda947700e74ac97f40 100644
--- a/android_webview/common/render_view_messages.h
+++ b/android_webview/common/render_view_messages.h
@@ -99,3 +99,12 @@ IPC_MESSAGE_ROUTED1(AwViewHostMsg_PageScaleFactorChanged,
 // Sent whenever the contents size (as seen by RenderView) is changed.
 IPC_MESSAGE_ROUTED1(AwViewHostMsg_OnContentsSizeChanged,
                     gfx::Size /* contents_size */)
+
+// Sent immediately before the main frame (top level) navigation is initiated

[boliu, 2013/12/06 20:28:23]

the main frame comment is not correct anymore

[sgurun-gerrit only, 2013/12/07 00:11:07]

Done.

+// within Blink to allow the browser process to cancel that navigation. This is
+// sent before updating the NavigationController state or creating a URLRequest
+// for the main frame resource.
+IPC_SYNC_MESSAGE_CONTROL2_1(AwViewHostMsg_ShouldOverrideUrlLoading,
+                            int /* view id */,

[boliu, 2013/12/06 20:28:23]

rouding_id?

[sgurun-gerrit only, 2013/12/07 00:11:07]

Done.

+                            string16 /* in - url */,

[boliu, 2013/12/06 20:28:23]

why not GURL?

[sgurun-gerrit only, 2013/12/07 00:11:07]

Initially the intention was in shouldoverwriteurlloading non-GURL strings would
also work, or at least to have the infrastructure to have them work i.e. the
extreme json string case and others, hence the code. Since we will shortly throw
away the SYNC IPC code in favor of what Darin wants, I don't think we want to
change it to GURL now.

[boliu, 2013/12/07 01:22:18]

Oh yeah...that. Now I remember

+                            bool /* out - result */)