android_webview/common/render_view_messages.h - Issue 24228003: Upstream ShouldOverrideUrlLoading changes

Side by Side Diff: android_webview/common/render_view_messages.h

Issue 24228003: Upstream ShouldOverrideUrlLoading changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added a test Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc ('K') | « android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc ('k') | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included file, no traditional include guard.	5 // Multiply-included file, no traditional include guard.

6 #include "android_webview/common/aw_hit_test_data.h"	6 #include "android_webview/common/aw_hit_test_data.h"

7 #include "content/public/common/common_param_traits.h"	7 #include "content/public/common/common_param_traits.h"

8 #include "ipc/ipc_channel_handle.h"	8 #include "ipc/ipc_channel_handle.h"

9 #include "ipc/ipc_message_macros.h"	9 #include "ipc/ipc_message_macros.h"

10 #include "ipc/ipc_platform_file.h"	10 #include "ipc/ipc_platform_file.h"

(...skipping 81 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
92 IPC_MESSAGE_ROUTED1(AwViewHostMsg_UpdateHitTestData,	92 IPC_MESSAGE_ROUTED1(AwViewHostMsg_UpdateHitTestData,

93 android_webview::AwHitTestData)	93 android_webview::AwHitTestData)

94	94

95 // Sent whenever the page scale factor (as seen by RenderView) is changed.	95 // Sent whenever the page scale factor (as seen by RenderView) is changed.

96 IPC_MESSAGE_ROUTED1(AwViewHostMsg_PageScaleFactorChanged,	96 IPC_MESSAGE_ROUTED1(AwViewHostMsg_PageScaleFactorChanged,

97 float /* page_scale_factor */)	97 float /* page_scale_factor */)

98	98

99 // Sent whenever the contents size (as seen by RenderView) is changed.	99 // Sent whenever the contents size (as seen by RenderView) is changed.

100 IPC_MESSAGE_ROUTED1(AwViewHostMsg_OnContentsSizeChanged,	100 IPC_MESSAGE_ROUTED1(AwViewHostMsg_OnContentsSizeChanged,

101 gfx::Size /* contents_size */)	101 gfx::Size /* contents_size */)

	102

	103 // Sent immediately before the main frame (top level) navigation is initiated
	boliu 2013/12/06 20:28:23 the main frame comment is not correct anymore the main frame comment is not correct anymore sgurun-gerrit only 2013/12/07 00:11:07 Done. Show quoted text On 2013/12/06 20:28:23, boliu wrote: > the main frame comment is not correct anymore Done.
	104 // within Blink to allow the browser process to cancel that navigation. This is

	105 // sent before updating the NavigationController state or creating a URLRequest

	106 // for the main frame resource.

	107 IPC_SYNC_MESSAGE_CONTROL2_1(AwViewHostMsg_ShouldOverrideUrlLoading,

	108 int /* view id */,
	boliu 2013/12/06 20:28:23 rouding_id? rouding_id? sgurun-gerrit only 2013/12/07 00:11:07 Done. Show quoted text On 2013/12/06 20:28:23, boliu wrote: > rouding_id? Done.
	109 string16 /* in - url */,
	boliu 2013/12/06 20:28:23 why not GURL? why not GURL? sgurun-gerrit only 2013/12/07 00:11:07 Initially the intention was in shouldoverwriteurll Show quoted text On 2013/12/06 20:28:23, boliu wrote: > why not GURL? Initially the intention was in shouldoverwriteurlloading non-GURL strings would also work, or at least to have the infrastructure to have them work i.e. the extreme json string case and others, hence the code. Since we will shortly throw away the SYNC IPC code in favor of what Darin wants, I don't think we want to change it to GURL now. boliu 2013/12/07 01:22:18 Oh yeah...that. Now I remember Show quoted text On 2013/12/07 00:11:07, sgurun wrote: > On 2013/12/06 20:28:23, boliu wrote: > > why not GURL? > > Initially the intention was in shouldoverwriteurlloading non-GURL strings would > also work, or at least to have the infrastructure to have them work i.e. the > extreme json string case and others, hence the code. Oh yeah...that. Now I remember Show quoted text > Since we will shortly throw > away the SYNC IPC code in favor of what Darin wants, I don't think we want to > change it to GURL now.
	110 bool /* out - result */)

OLD	NEW