Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: third_party/WebKit/public/platform/WebMessagePortChannel.h

Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle (Closed)
Patch Set: Add metrics and support for non-ASCII text messages to Java endpoints Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebMessagePortChannel.h
diff --git a/third_party/WebKit/public/platform/WebMessagePortChannel.h b/third_party/WebKit/public/platform/WebMessagePortChannel.h
index 0739fbf0a02b8d2b8a74d9b443aa03891c6e0795..41ec19c35a68ef4c05101d6f8dec79ca884f8046 100644
--- a/third_party/WebKit/public/platform/WebMessagePortChannel.h
+++ b/third_party/WebKit/public/platform/WebMessagePortChannel.h
@@ -50,28 +50,17 @@ typedef WebVector<class WebMessagePortChannel*> WebMessagePortChannelArray;
// call.
kinuko 2017/01/24 12:32:55 This comment is stale now?
darin (slow to review) 2017/01/26 22:20:03 Yes, thanks
class WebMessagePortChannel {
public:
+ virtual ~WebMessagePortChannel() {}
virtual void setClient(WebMessagePortChannelClient*) = 0;
- virtual void destroy() = 0;
// Callee receives ownership of the passed vector.
// FIXME: Blob refs should be passed to maintain ref counts. crbug.com/351753
virtual void postMessage(const WebString&, WebMessagePortChannelArray*) = 0;
virtual bool tryGetMessage(WebString*, WebMessagePortChannelArray&) = 0;
-
- protected:
- ~WebMessagePortChannel() {}
};
#if INSIDE_BLINK
-struct WebMessagePortChannelDeleter {
- void operator()(WebMessagePortChannel* channel) {
- if (channel)
- channel->destroy();
- }
-};
-
-using WebMessagePortChannelUniquePtr =
- std::unique_ptr<WebMessagePortChannel, WebMessagePortChannelDeleter>;
+using WebMessagePortChannelUniquePtr = std::unique_ptr<WebMessagePortChannel>;
#endif // INSIDE_BLINK

Powered by Google App Engine
This is Rietveld 408576698