HTML MessagePort as mojo::MessagePipeHandle

third_party/WebKit/public/platform/WebMessagePortChannel.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 25 matching lines @@
 
 #if INSIDE_BLINK
 #include <memory>
 #endif
 
 namespace blink {
 
 class WebMessagePortChannelClient;
 class WebString;
 
 typedef WebVector<class WebMessagePortChannel*> WebMessagePortChannelArray;

[kinuko, 2017/01/24 12:32:55]

Should this probably be a vector of std::unique_ptr<WebMessagePortChannel>?

[darin (slow to review), 2017/01/26 22:20:03]

Great idea

 
 // Provides an interface to a Message Port Channel implementation. The object
 // owns itself and is signalled that its not needed anymore with the destroy()
 // call.

[kinuko, 2017/01/24 12:32:55]

This comment is stale now?

[darin (slow to review), 2017/01/26 22:20:03]

Yes, thanks

 class WebMessagePortChannel {
  public:
+  virtual ~WebMessagePortChannel() {}
   virtual void setClient(WebMessagePortChannelClient*) = 0;
-  virtual void destroy() = 0;
   // Callee receives ownership of the passed vector.
   // FIXME: Blob refs should be passed to maintain ref counts. crbug.com/351753
   virtual void postMessage(const WebString&, WebMessagePortChannelArray*) = 0;
   virtual bool tryGetMessage(WebString*, WebMessagePortChannelArray&) = 0;
-
- protected:
-  ~WebMessagePortChannel() {}
 };
 
 #if INSIDE_BLINK
 
-struct WebMessagePortChannelDeleter {
-  void operator()(WebMessagePortChannel* channel) {
-    if (channel)
-      channel->destroy();
-  }
-};
-
-using WebMessagePortChannelUniquePtr =
-    std::unique_ptr<WebMessagePortChannel, WebMessagePortChannelDeleter>;
+using WebMessagePortChannelUniquePtr = std::unique_ptr<WebMessagePortChannel>;
 
 #endif  // INSIDE_BLINK
 
 }  // namespace blink
 
 #endif  // WebMessagePortChannel_h