Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: third_party/WebKit/Source/core/dom/MessagePort.h

Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle (Closed)
Patch Set: Add missing ScopedAsyncTaskScheduler instance for the new unit tests; required by a recent change t… Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/MessagePort.h
diff --git a/third_party/WebKit/Source/core/dom/MessagePort.h b/third_party/WebKit/Source/core/dom/MessagePort.h
index af79d4581ff95b107ffbaf69ad18b14fb3dc35bf..1668f745745730b02389c0160f3bc59ee05e82bc 100644
--- a/third_party/WebKit/Source/core/dom/MessagePort.h
+++ b/third_party/WebKit/Source/core/dom/MessagePort.h
@@ -75,24 +75,22 @@ class CORE_EXPORT MessagePort : public EventTargetWithInlineData,
void entangle(WebMessagePortChannelUniquePtr);
WebMessagePortChannelUniquePtr disentangle();
- // Returns nullptr if the passed-in array is nullptr/empty.
- static std::unique_ptr<WebMessagePortChannelArray>
- toWebMessagePortChannelArray(std::unique_ptr<MessagePortChannelArray>);
+ static WebMessagePortChannelArray toWebMessagePortChannelArray(
+ MessagePortChannelArray);
// Returns an empty array if the passed array is empty.
- static MessagePortArray* toMessagePortArray(
- ExecutionContext*,
- const WebMessagePortChannelArray&);
+ static MessagePortArray* toMessagePortArray(ExecutionContext*,
+ WebMessagePortChannelArray);
- // Returns nullptr if there is an exception, or if the passed-in array is
+ // Returns an empty array if there is an exception, or if the passed array is
// nullptr/empty.
- static std::unique_ptr<MessagePortChannelArray>
- disentanglePorts(ExecutionContext*, const MessagePortArray&, ExceptionState&);
+ static MessagePortChannelArray disentanglePorts(ExecutionContext*,
+ const MessagePortArray&,
+ ExceptionState&);
- // Returns an empty array if the passed array is nullptr/empty.
- static MessagePortArray* entanglePorts(
- ExecutionContext&,
- std::unique_ptr<MessagePortChannelArray>);
+ // Returns an empty array if the passed array is empty.
+ static MessagePortArray* entanglePorts(ExecutionContext&,
+ MessagePortChannelArray);
bool started() const { return m_started; }
@@ -134,7 +132,7 @@ class CORE_EXPORT MessagePort : public EventTargetWithInlineData,
protected:
explicit MessagePort(ExecutionContext&);
bool tryGetMessage(RefPtr<SerializedScriptValue>& message,
- std::unique_ptr<MessagePortChannelArray>& channels);
+ MessagePortChannelArray& channels);
private:
// WebMessagePortChannelClient implementation.

Powered by Google App Engine
This is Rietveld 408576698