Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp

Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle (Closed)
Patch Set: Add missing ScopedAsyncTaskScheduler instance for the new unit tests; required by a recent change t… Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
index c9414d97322eeb21254aee0a5df30a5c1d6b7b0d..285f31becdb12290cc1718644aaf2df3ff3221d3 100644
--- a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
@@ -63,7 +63,7 @@ v8::Local<v8::Value> roundTrip(v8::Local<v8::Value> value,
: scope.getExceptionState();
// Extract message ports and disentangle them.
- std::unique_ptr<MessagePortChannelArray> channels;
+ MessagePortChannelArray channels;
if (transferables) {
channels = MessagePort::disentanglePorts(scope.getExecutionContext(),
transferables->messagePorts,
@@ -239,8 +239,7 @@ class WebMessagePortChannelImpl final : public WebMessagePortChannel {
public:
// WebMessagePortChannel
void setClient(WebMessagePortChannelClient* client) override {}
- void destroy() override { delete this; }
- void postMessage(const WebString&, WebMessagePortChannelArray*) {
+ void postMessage(const WebString&, WebMessagePortChannelArray) {
NOTIMPLEMENTED();
}
bool tryGetMessage(WebString*, WebMessagePortChannelArray&) { return false; }

Powered by Google App Engine
This is Rietveld 408576698