Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: chrome/install_static/BUILD.gn

Issue 2422643002: Windows install_static refactor. (Closed)
Patch Set: sync to position 431863 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/install_static/BUILD.gn
diff --git a/chrome/install_static/BUILD.gn b/chrome/install_static/BUILD.gn
index 4804e261e81a4aa40cfb4aafc2ba44073622b6dc..c3e624810da2d75b40014cf85afaa7c636a6682b 100644
--- a/chrome/install_static/BUILD.gn
+++ b/chrome/install_static/BUILD.gn
@@ -10,15 +10,38 @@ assert(is_win)
# This file only contains utility functions which must only depend on kernel32.
# Please don't add dependencies on other system libraries.
static_library("install_static_util") {
+ deps = [
+ "//components/version_info:generate_version_info",
+ ]
+
public_deps = [
"//chrome_elf:nt_registry",
]
sources = [
+ "install_constants.h",
+ "install_details.cc",
+ "install_details.h",
+ "install_modes.cc",
+ "install_modes.h",
"install_util.cc",
"install_util.h",
+ "product_install_details.cc",
+ "product_install_details.h",
]
+ if (is_chrome_branded) {
+ sources += [
+ "google_chrome_install_modes.cc",
+ "google_chrome_install_modes.h",
+ ]
+ } else {
+ sources += [
+ "chromium_install_modes.cc",
+ "chromium_install_modes.h",
+ ]
+ }
+
libs = [ "kernel32.lib" ]
configs += [
@@ -30,7 +53,10 @@ static_library("install_static_util") {
test("install_static_unittests") {
output_name = "install_static_unittests"
sources = [
+ "install_details_unittest.cc",
+ "install_modes_unittest.cc",
"install_util_unittest.cc",
+ "product_install_details_unittest.cc",
]
include_dirs = [ "$target_gen_dir" ]
deps = [

Powered by Google App Engine
This is Rietveld 408576698