Windows install_static refactor.

chrome/install_static/chromium_install_modes.h

Index: chrome/install_static/chromium_install_modes.h
diff --git a/chrome/install_static/chromium_install_modes.h b/chrome/install_static/chromium_install_modes.h
new file mode 100644
index 0000000000000000000000000000000000000000..cabe84978aaebe3155d9c481a654180f596ca41e
--- /dev/null
+++ b/chrome/install_static/chromium_install_modes.h
@@ -0,0 +1,23 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Brand-specific types and constants for Chromium.
+
+#ifndef CHROME_INSTALL_STATIC_CHROMIUM_INSTALL_MODES_H_
+#define CHROME_INSTALL_STATIC_CHROMIUM_INSTALL_MODES_H_
+
+namespace install_static {
+
+enum : bool {
+  kUseGoogleUpdateIntegration = false,

[Nico, 2017/09/11 01:12:24]

What's the point of this constant? Maybe there could be a comment explaining
this?

(Background: I'm looking at turning on -Wunreachable-code, and I'm getting
things like

../../chrome/install_static/install_details_unittest.cc(27,28):  error: code
will never be executed [-Werror,-Wunreachable-code]
      constants.app_guid = L"testguid";
                           ^~~~~~~~~~~

and I'm having trouble making sense of the warning. It's obviously correct, but
I'm not sure what to to about it since I don't understand what this constant
here is for.)

[grt (UTC plus 2), 2017/09/11 12:31:37]

It controls whether or not Omaha integration is included in the build. A
buildflag would have been a better choice. I think it would be nice to switch
from this to a buildflag at some point.
The comment is in install_modes.h:

// - kUseGoogleUpdateIntegration: true or false indicating whether or not the
//   brand uses Chrome's integration with Google Update. Google Chrome does,
//   while Chromium does not.

[Nico, 2017/09/14 21:53:20]

Thanks for the explanation. I still don't quite understand it: How do we set
this bool to true? Does the release builder carry a local patch to this file?

[grt (UTC plus 2), 2017/09/15 11:25:31]

No. The value is unconditionally false for Chromium builds. This file
(chromium_install_modes.h) is a brand-specific file for Chromium. The
corresponding file for Google Chrome (google_chrome_install_modes.h) sets it to 
true for Google Chrome-branded builds.

+};
+
+enum InstallConstantIndex {
+  CHROMIUM_INDEX,
+  NUM_INSTALL_MODES,
+};
+
+}  // namespace install_static
+
+#endif  // CHROME_INSTALL_STATIC_CHROMIUM_INSTALL_MODES_H_