Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2422633002: [NTP Snippets] Properly restore the status of restored sections (Closed)

Created:
4 years, 2 months ago by Marc Treib
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Properly restore the status of restored sections BUG=655969 Committed: https://crrev.com/39fffa156f0b841bccf32abfb68e8802c28bae2f Cr-Commit-Position: refs/heads/master@{#425323}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -16 lines) Patch
M components/ntp_snippets/content_suggestions_service.cc View 1 chunk +4 lines, -1 line 0 comments Download
M components/ntp_snippets/remote/ntp_snippets_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/ntp_snippets/remote/ntp_snippets_service.cc View 2 chunks +9 lines, -7 lines 1 comment Download
M components/ntp_snippets/remote/ntp_snippets_service_unittest.cc View 3 chunks +15 lines, -8 lines 0 comments Download

Dependent Patchsets:

Issue 2421823003 Patch 1

Messages

Total messages: 8 (3 generated)
Marc Treib
PTAL! https://codereview.chromium.org/2422633002/diff/1/components/ntp_snippets/remote/ntp_snippets_service.cc File components/ntp_snippets/remote/ntp_snippets_service.cc (right): https://codereview.chromium.org/2422633002/diff/1/components/ntp_snippets/remote/ntp_snippets_service.cc#newcode839 components/ntp_snippets/remote/ntp_snippets_service.cc:839: for (const auto& item : categories_) { This ...
4 years, 2 months ago (2016-10-14 13:47:15 UTC) #2
Bernhard Bauer
lgtm
4 years, 2 months ago (2016-10-14 14:14:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422633002/1
4 years, 2 months ago (2016-10-14 14:23:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 14:59:34 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 15:01:05 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/39fffa156f0b841bccf32abfb68e8802c28bae2f
Cr-Commit-Position: refs/heads/master@{#425323}

Powered by Google App Engine
This is Rietveld 408576698