components/ntp_snippets/remote/ntp_snippets_service.h - Issue 2422633002: [NTP Snippets] Properly restore the status of restored sections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/remote/ntp_snippets_service.h

Issue 2422633002: [NTP Snippets] Properly restore the status of restored sections (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/remote/ntp_snippets_service.h

diff --git a/components/ntp_snippets/remote/ntp_snippets_service.h b/components/ntp_snippets/remote/ntp_snippets_service.h

index 7d7cd6a4fbab61a5bd9454d92632b91306866f75..af9c017bafbe1f0903c0e174b8afc768348eedfa 100644

--- a/components/ntp_snippets/remote/ntp_snippets_service.h

+++ b/components/ntp_snippets/remote/ntp_snippets_service.h

@@ -130,6 +130,7 @@ class NTPSnippetsService final : public ContentSuggestionsProvider,

static int GetMaxSnippetCountForTesting();

// Available snippets, only for unit tests.

+ // TODO(treib): Get rid of this. Tests should use a fake observer instead.

const NTPSnippet::PtrVector& GetSnippetsForTesting(Category category) const {

return categories_.find(category)->second.snippets;

}