Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2422423002: Use md-select instead of paper-dropdown-menu-light in internet page (Closed)

Created:
4 years, 2 months ago by stevenjb
Modified:
4 years, 2 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use md-select instead of paper-dropdown-menu-light in internet page BUG=653689 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b0e7fb52816a7b5efc7c1ca92a99cb3e5a6d1e15 Cr-Commit-Position: refs/heads/master@{#425853}

Patch Set 1 #

Total comments: 11

Patch Set 2 : Use data binding + async #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -58 lines) Patch
M chrome/browser/resources/settings/internet_page/network_apnlist.html View 1 1 chunk +9 lines, -12 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_apnlist.js View 1 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_nameservers.html View 1 1 chunk +9 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_nameservers.js View 1 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy.html View 1 2 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy.js View 1 5 chunks +16 lines, -14 lines 2 comments Download

Messages

Total messages: 16 (5 generated)
stevenjb
4 years, 2 months ago (2016-10-17 22:36:00 UTC) #3
dpapad
https://codereview.chromium.org/2422423002/diff/1/chrome/browser/resources/settings/internet_page/network_apnlist.js File chrome/browser/resources/settings/internet_page/network_apnlist.js (left): https://codereview.chromium.org/2422423002/diff/1/chrome/browser/resources/settings/internet_page/network_apnlist.js#oldcode144 chrome/browser/resources/settings/internet_page/network_apnlist.js:144: // We need to flush the DOM here, otherwise ...
4 years, 2 months ago (2016-10-17 22:57:05 UTC) #4
stevenjb
https://codereview.chromium.org/2422423002/diff/1/chrome/browser/resources/settings/internet_page/network_apnlist.js File chrome/browser/resources/settings/internet_page/network_apnlist.js (left): https://codereview.chromium.org/2422423002/diff/1/chrome/browser/resources/settings/internet_page/network_apnlist.js#oldcode144 chrome/browser/resources/settings/internet_page/network_apnlist.js:144: // We need to flush the DOM here, otherwise ...
4 years, 2 months ago (2016-10-17 23:10:19 UTC) #5
stevenjb
PTAL Note: I used async() in all 3 cases so that we don't have to ...
4 years, 2 months ago (2016-10-17 23:58:01 UTC) #6
dpapad
On 2016/10/17 at 23:58:01, stevenjb wrote: > PTAL > > Note: I used async() in ...
4 years, 2 months ago (2016-10-18 00:09:39 UTC) #8
dpapad
LGTM. https://codereview.chromium.org/2422423002/diff/40001/chrome/browser/resources/settings/internet_page/network_proxy.js File chrome/browser/resources/settings/internet_page/network_proxy.js (right): https://codereview.chromium.org/2422423002/diff/40001/chrome/browser/resources/settings/internet_page/network_proxy.js#newcode152 chrome/browser/resources/settings/internet_page/network_proxy.js:152: useSameProxyChanged_: function() { Nit: This seems to have ...
4 years, 2 months ago (2016-10-18 00:09:51 UTC) #9
stevenjb
On 2016/10/18 00:09:39, dpapad wrote: > On 2016/10/17 at 23:58:01, stevenjb wrote: > > PTAL ...
4 years, 2 months ago (2016-10-18 00:31:02 UTC) #10
stevenjb
https://codereview.chromium.org/2422423002/diff/40001/chrome/browser/resources/settings/internet_page/network_proxy.js File chrome/browser/resources/settings/internet_page/network_proxy.js (right): https://codereview.chromium.org/2422423002/diff/40001/chrome/browser/resources/settings/internet_page/network_proxy.js#newcode152 chrome/browser/resources/settings/internet_page/network_proxy.js:152: useSameProxyChanged_: function() { On 2016/10/18 00:09:51, dpapad wrote: > ...
4 years, 2 months ago (2016-10-18 00:32:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422423002/40001
4 years, 2 months ago (2016-10-18 00:33:33 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-18 02:00:09 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 02:02:31 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b0e7fb52816a7b5efc7c1ca92a99cb3e5a6d1e15
Cr-Commit-Position: refs/heads/master@{#425853}

Powered by Google App Engine
This is Rietveld 408576698