Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chrome/browser/resources/settings/internet_page/network_nameservers.js

Issue 2422423002: Use md-select instead of paper-dropdown-menu-light in internet page (Closed)
Patch Set: Use data binding + async Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/network_nameservers.js
diff --git a/chrome/browser/resources/settings/internet_page/network_nameservers.js b/chrome/browser/resources/settings/internet_page/network_nameservers.js
index cec1b79e122d21cecc6415778cdc043a749703fb..db50135fcbb67a222d5a041864da076ed505dfe9 100644
--- a/chrome/browser/resources/settings/internet_page/network_nameservers.js
+++ b/chrome/browser/resources/settings/internet_page/network_nameservers.js
@@ -108,13 +108,16 @@ Polymer({
* @private
*/
setNameservers_: function(nameserversType, nameservers) {
- this.nameserversType_ = nameserversType;
if (nameserversType == 'custom') {
// Add empty entries for unset custom nameservers.
for (let i = nameservers.length; i < this.MAX_NAMESERVERS; ++i)
nameservers[i] = '';
}
this.nameservers_ = nameservers;
+ // Set nameserversType_ after dom-repeat has been stamped.
+ this.async(function() {
+ this.nameserversType_ = nameserversType;
+ }.bind(this));
},
/**
@@ -142,13 +145,14 @@ Polymer({
/**
* Event triggered when the selected type changes. Updates nameservers and
* sends the change value if necessary.
- * @param {!{detail: !{selected: string}}} e
+ * @param {!Event} event
* @private
*/
- onTypeChange_: function(e) {
+ onTypeChange_: function(event) {
if (this.nameserversType_ == 'custom')
this.savedNameservers_ = this.nameservers_;
- var type = e.detail.selected;
+ let target = /** @type {!HTMLSelectElement} */ (event.target);
+ let type = target.value;
this.nameserversType_ = type;
if (type == 'custom') {
// Restore the saved nameservers.

Powered by Google App Engine
This is Rietveld 408576698