Iframe/div MD scrollbars get idle when mouse leaves the nested elements.

Iframe/div MD scrollbars get idle when mouse leaves the nested elements.

If the scrollbar of a nested element is not captured, it
should get back to idle state when mouse leaves the element.
Now, the scrollbar gets stuck in hover state if mouse leaves the nested element while being near the scrollbar.
With this change the non-captured scrollbars always get back to idle state when the mouse leaves the div/iframe.

BUG=636393
TEST=LayerTreeHostImplTest.LayerTreeHostImplTestScrollbarStates
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/db2d55e87ca8e0a8c74d29f479ec498053495e6f
Cr-Commit-Position: refs/heads/master@{#427343}

[sahel, 2016-10-17 21:05:34]

Description was changed from

==========
Iframe/div MD scrollbars get idle when mouse leaves the nested elements.

BUG=636393
==========

to

==========
Iframe/div MD scrollbars get idle when mouse leaves the nested elements.

BUG=636393
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[sahel, 2016-10-17 21:14:37]

Description was changed from

==========
Iframe/div MD scrollbars get idle when mouse leaves the nested elements.

BUG=636393
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Iframe/div MD scrollbars get idle when mouse leaves the nested elements.

If the scrollbar of a nested element is not captured, it
should get back to idle state when mouse leaves the element.
Now, the scrollbar gets stuck in hover state if mouse leaves the nested element
while being near the scrollbar.
With this change the non-captured scrollbars always get back to idle state when
the mouse leaves the div/iframe.

BUG=636393
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[sahel, 2016-10-17 21:14:43]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 21:15:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 23:16:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 23:16:45]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_TIMED_OUT, no build
URL)

[sahel, 2016-10-18 14:14:38]

sahel@chromium.org changed reviewers:
+ bokan@chromium.org

[bokan, 2016-10-18 15:44:35]

Also, this will need a test.

https://codereview.chromium.org/2422353002/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/2422353002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:3262: ScrollbarAnimationControllerForId(
Hmm...too much of this logic is starting to creep into LayerTreeHostImpl.
scroll_layer_id_when_mouse_near_scrollbar_ should always be the same layer as
scroll_layer_id_when_mouse_over_scrollbar_ (if the latter is non-null), right? I
think we could keep just one variable, scroll_layer_id_mouse_currently_over and
send the distance from scrollbar to the controller on each mouse move. The
controller could then keep all this state and make the transitions internally.

[sahel, 2016-10-19 21:01:57]

sahel@chromium.org changed reviewers:
+ chaopeng@chromium.org

[sahel, 2016-10-19 21:25:14]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 21:26:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sahel, 2016-10-19 21:29:17]

I haven't added a new test, yet.

https://codereview.chromium.org/2422353002/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/2422353002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:3262: ScrollbarAnimationControllerForId(
On 2016/10/18 15:44:35, bokan wrote:
> Hmm...too much of this logic is starting to creep into LayerTreeHostImpl.
> scroll_layer_id_when_mouse_near_scrollbar_ should always be the same layer as
> scroll_layer_id_when_mouse_over_scrollbar_ (if the latter is non-null), right?
I
> think we could keep just one variable, scroll_layer_id_mouse_currently_over
and
> send the distance from scrollbar to the controller on each mouse move. The
> controller could then keep all this state and make the transitions internally.

Done.

[commit-bot: I haz the power, 2016-10-19 23:03:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 23:03:12]

Dry run: This issue passed the CQ dry run.

[bokan, 2016-10-20 14:58:08]

Thanks, this looks great. Just needs a test.

https://codereview.chromium.org/2422353002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/2422353002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.cc:3271:
old_animation_controller->DidMouseMoveOffScrollbar();
Seems to me DidMouseMoveOffScrollbar should really be called, didMouseLeave.
Please rename.

[sahel, 2016-10-21 17:10:34]

Patchset #3 (id:40001) has been deleted

[sahel, 2016-10-21 17:19:04]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 17:19:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 17:22:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 17:22:01]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sahel, 2016-10-21 17:23:33]

Description was changed from

==========
Iframe/div MD scrollbars get idle when mouse leaves the nested elements.

If the scrollbar of a nested element is not captured, it
should get back to idle state when mouse leaves the element.
Now, the scrollbar gets stuck in hover state if mouse leaves the nested element
while being near the scrollbar.
With this change the non-captured scrollbars always get back to idle state when
the mouse leaves the div/iframe.

BUG=636393
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Iframe/div MD scrollbars get idle when mouse leaves the nested elements.

If the scrollbar of a nested element is not captured, it
should get back to idle state when mouse leaves the element.
Now, the scrollbar gets stuck in hover state if mouse leaves the nested element
while being near the scrollbar.
With this change the non-captured scrollbars always get back to idle state when
the mouse leaves the div/iframe.

BUG=656657, 636393
TEST=LayerTreeHostImplTest.LayerTreeHostImplTestScrollbarStates
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[sahel, 2016-10-21 18:30:55]

Patchset #3 (id:60001) has been deleted

[sahel, 2016-10-21 18:35:37]

Patchset #3 (id:80001) has been deleted

[sahel, 2016-10-21 18:41:05]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 18:41:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 22:27:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:27:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sahel, 2016-10-24 19:44:23]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 19:45:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sahel, 2016-10-24 21:17:51]

Description was changed from

==========
Iframe/div MD scrollbars get idle when mouse leaves the nested elements.

If the scrollbar of a nested element is not captured, it
should get back to idle state when mouse leaves the element.
Now, the scrollbar gets stuck in hover state if mouse leaves the nested element
while being near the scrollbar.
With this change the non-captured scrollbars always get back to idle state when
the mouse leaves the div/iframe.

BUG=656657, 636393
TEST=LayerTreeHostImplTest.LayerTreeHostImplTestScrollbarStates
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Iframe/div MD scrollbars get idle when mouse leaves the nested elements.

If the scrollbar of a nested element is not captured, it
should get back to idle state when mouse leaves the element.
Now, the scrollbar gets stuck in hover state if mouse leaves the nested element
while being near the scrollbar.
With this change the non-captured scrollbars always get back to idle state when
the mouse leaves the div/iframe.

BUG=636393
TEST=LayerTreeHostImplTest.LayerTreeHostImplTestScrollbarStates
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-10-24 21:21:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 21:21:20]

Dry run: This issue passed the CQ dry run.

[sahel, 2016-10-24 21:22:06]

The added unittest fails without this cl.

https://codereview.chromium.org/2422353002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/2422353002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.cc:3271:
old_animation_controller->DidMouseMoveOffScrollbar();
On 2016/10/20 14:58:08, bokan wrote:
> Seems to me DidMouseMoveOffScrollbar should really be called, didMouseLeave.
> Please rename.

Done.

[sahel, 2016-10-24 21:26:58]

sahel@chromium.org changed reviewers:
+ aelias@chromium.org

[sahel, 2016-10-24 21:26:58]

aelias@chromium.org: Please review changes in

[aelias_OOO_until_Jul13, 2016-10-24 21:54:14]

lgtm

[chaopeng, 2016-10-24 23:16:52]

On 2016/10/24 21:54:14, aelias wrote:
> lgtm

lgtm

[sahel, 2016-10-25 14:17:41]

The CQ bit was checked by sahel@chromium.org

[commit-bot: I haz the power, 2016-10-25 14:17:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 14:22:10]

Description was changed from

==========
Iframe/div MD scrollbars get idle when mouse leaves the nested elements.

If the scrollbar of a nested element is not captured, it
should get back to idle state when mouse leaves the element.
Now, the scrollbar gets stuck in hover state if mouse leaves the nested element
while being near the scrollbar.
With this change the non-captured scrollbars always get back to idle state when
the mouse leaves the div/iframe.

BUG=636393
TEST=LayerTreeHostImplTest.LayerTreeHostImplTestScrollbarStates
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Iframe/div MD scrollbars get idle when mouse leaves the nested elements.

If the scrollbar of a nested element is not captured, it
should get back to idle state when mouse leaves the element.
Now, the scrollbar gets stuck in hover state if mouse leaves the nested element
while being near the scrollbar.
With this change the non-captured scrollbars always get back to idle state when
the mouse leaves the div/iframe.

BUG=636393
TEST=LayerTreeHostImplTest.LayerTreeHostImplTestScrollbarStates
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-10-25 14:22:12]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-10-25 14:24:41]

Description was changed from

==========
Iframe/div MD scrollbars get idle when mouse leaves the nested elements.

If the scrollbar of a nested element is not captured, it
should get back to idle state when mouse leaves the element.
Now, the scrollbar gets stuck in hover state if mouse leaves the nested element
while being near the scrollbar.
With this change the non-captured scrollbars always get back to idle state when
the mouse leaves the div/iframe.

BUG=636393
TEST=LayerTreeHostImplTest.LayerTreeHostImplTestScrollbarStates
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Iframe/div MD scrollbars get idle when mouse leaves the nested elements.

If the scrollbar of a nested element is not captured, it
should get back to idle state when mouse leaves the element.
Now, the scrollbar gets stuck in hover state if mouse leaves the nested element
while being near the scrollbar.
With this change the non-captured scrollbars always get back to idle state when
the mouse leaves the div/iframe.

BUG=636393
TEST=LayerTreeHostImplTest.LayerTreeHostImplTestScrollbarStates
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/db2d55e87ca8e0a8c74d29f479ec498053495e6f
Cr-Commit-Position: refs/heads/master@{#427343}
==========

[commit-bot: I haz the power, 2016-10-25 14:24:42]

Patchset 4 (id:??) landed as
https://crrev.com/db2d55e87ca8e0a8c74d29f479ec498053495e6f
Cr-Commit-Position: refs/heads/master@{#427343}