Minor tweaks to dart:html for better dart2js codegen

Minor tweaks to dart:html for better dart2js codegen

- Allow 'document' to be reused (GVN-ed).
- Allow inlining of 'new Comment'.
- 'new Text' and 'new Comment' have no effects.

BUG=
R=alanknight@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/c9c3c203c155d92cf86cceec0b9168e86429dd80

[sra1, 2016-10-17 18:29:20]

Patchset #1 (id:1) has been deleted

[sra1, 2016-10-17 19:08:49]

Patchset #1 (id:20001) has been deleted

[sra1, 2016-10-17 19:14:32]

Description was changed from

==========
Allow GVN-ing of 'document'

BUG=
==========

to

==========
Allow GVN-ing of 'document'.

BUG=
==========

[sra1, 2016-10-17 19:21:16]

Description was changed from

==========
Allow GVN-ing of 'document'.

BUG=
==========

to

==========
Minor tweaks to dart:html for better dart2js codegen

- Allow 'document' to be reused (GVN-ed).
- Allow inlining of 'new Comment'.
- 'new Text' and 'new Comment' have no effects.

BUG=
==========

[sra1, 2016-10-17 19:21:16]

sra@google.com changed reviewers:
+ alanknight@google.com, sigmund@google.com

[Alan Knight, 2016-10-17 19:29:10]

lgtm

[Siggi Cherem (dart-lang), 2016-10-17 19:36:59]

lgtm

[Florian Schneider, 2016-10-17 19:40:26]

fschneider@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-10-17 19:40:27]

dbc: I thought this file is auto-generated. At least that's what is says about
itself.

// DO NOT EDIT - unless you are editing documentation as per:
// https://code.google.com/p/dart/wiki/ContributingHTMLDocumentation
// Auto-generated dart:html library.

[Alan Knight, 2016-10-17 19:44:16]

On 2016/10/17 19:40:27, Florian Schneider wrote:
> dbc: I thought this file is auto-generated. At least that's what is says about
> itself.
> 
> // DO NOT EDIT - unless you are editing documentation as per:
> // https://code.google.com/p/dart/wiki/ContributingHTMLDocumentation
> // Auto-generated dart:html library.

It is, but via a separate script, not part of the build process. So it needs to
get regenerated and then checked in.

[sra1, 2016-10-17 20:35:35]

Description was changed from

==========
Minor tweaks to dart:html for better dart2js codegen

- Allow 'document' to be reused (GVN-ed).
- Allow inlining of 'new Comment'.
- 'new Text' and 'new Comment' have no effects.

BUG=
==========

to

==========
Minor tweaks to dart:html for better dart2js codegen

- Allow 'document' to be reused (GVN-ed).
- Allow inlining of 'new Comment'.
- 'new Text' and 'new Comment' have no effects.

BUG=
R=alanknight@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c9c3c203c155d92cf86cceec0b9168e86429dd80
==========

[sra1, 2016-10-17 20:35:36]

Committed patchset #1 (id:40001) manually as
c9c3c203c155d92cf86cceec0b9168e86429dd80 (presubmit successful).

[Florian Schneider, 2016-10-17 20:48:46]

On 2016/10/17 19:44:16, Alan Knight wrote:
> On 2016/10/17 19:40:27, Florian Schneider wrote:
> > dbc: I thought this file is auto-generated. At least that's what is says
about
> > itself.
> > 
> > // DO NOT EDIT - unless you are editing documentation as per:
> > // https://code.google.com/p/dart/wiki/ContributingHTMLDocumentation
> > // Auto-generated dart:html library.
> 
> It is, but via a separate script, not part of the build process. So it needs
to
> get regenerated and then checked in.

I guess my question is: Why not have this generated as part of the SDK build
process?

[sra1, 2016-10-17 21:05:05]

On 2016/10/17 20:48:46, Florian Schneider wrote:
> On 2016/10/17 19:44:16, Alan Knight wrote:
> > On 2016/10/17 19:40:27, Florian Schneider wrote:
> > > dbc: I thought this file is auto-generated. At least that's what is says
> about
> > > itself.
> > > 
> > > // DO NOT EDIT - unless you are editing documentation as per:
> > > // https://code.google.com/p/dart/wiki/ContributingHTMLDocumentation
> > > // Auto-generated dart:html library.
> > 
> > It is, but via a separate script, not part of the build process. So it needs
> to
> > get regenerated and then checked in.
> 
> I guess my question is: Why not have this generated as part of the SDK build
> process?

In the general case it depends on Dartium.
My change just happened to avoid changing anything (that matters) for Dartium.
You don't want to build Chrome for every VM change.