Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: tools/dom/templates/html/impl/impl_Comment.darttemplate

Issue 2422293002: Minor tweaks to dart:html for better dart2js codegen (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/templates/html/impl/impl_Comment.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Comment.darttemplate b/tools/dom/templates/html/impl/impl_Comment.darttemplate
index dc6e5741ee89938f61bf361c941215fe57138b47..9934bb0108abaa1046127f576741b1e061fc2fda 100644
--- a/tools/dom/templates/html/impl/impl_Comment.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Comment.darttemplate
@@ -8,10 +8,8 @@ part of $LIBRARYNAME;
$(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$MIXINS$IMPLEMENTS {
$if DART2JS
factory Comment([String data]) {
- if (data != null) {
- return JS('Comment', '#.createComment(#)', document, data);
- }
- return JS('Comment', '#.createComment("")', document);
+ return JS('returns:Comment;depends:none;effects:none;new:true',
+ '#.createComment(#)', document, data == null ? "" : data);
}
$endif
$!MEMBERS}
« no previous file with comments | « tools/dom/templates/html/dart2js/html_dart2js.darttemplate ('k') | tools/dom/templates/html/impl/impl_Text.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698