Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 2422203002: gn: bootstrap: always use cxx for linking (Closed)

Created:
4 years, 2 months ago by Mike Gilbert
Modified:
4 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: bootstrap: always use cxx for linking LD may be set to something like "ld.bfd" or "ld.gold". We want to let the compiler invoke the linker instead of calling these directly. Bug: https://bugs.gentoo.org/597218 Committed: https://crrev.com/11aa518d0b8d280fdc5958ae440a4f799fa6ac56 Cr-Commit-Position: refs/heads/master@{#425723}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/bootstrap/bootstrap.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Mike Gilbert
Please review.
4 years, 2 months ago (2016-10-17 15:28:54 UTC) #3
brettw
lgtm
4 years, 2 months ago (2016-10-17 17:50:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422203002/1
4 years, 2 months ago (2016-10-17 17:54:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 18:05:33 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 18:07:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11aa518d0b8d280fdc5958ae440a4f799fa6ac56
Cr-Commit-Position: refs/heads/master@{#425723}

Powered by Google App Engine
This is Rietveld 408576698