Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2422173003: [regexp] Work around gcc bug triggering -Werror=strict-overflow (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Work around gcc bug triggering -Werror=strict-overflow BUG=v8:5526 Committed: https://crrev.com/0e0123a61cf5d205137fc80cef44260f511c4594 Cr-Commit-Position: refs/heads/master@{#40368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/runtime/runtime-regexp.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/vector.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
jgruber
4 years, 2 months ago (2016-10-17 14:40:30 UTC) #4
Igor Sheludko
lgtm
4 years, 2 months ago (2016-10-17 14:58:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422173003/1
4 years, 2 months ago (2016-10-17 15:02:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 15:12:49 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 15:13:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e0123a61cf5d205137fc80cef44260f511c4594
Cr-Commit-Position: refs/heads/master@{#40368}

Powered by Google App Engine
This is Rietveld 408576698