src/runtime/runtime-regexp.cc - Issue 2422173003: [regexp] Work around gcc bug triggering -Werror=strict-overflow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-regexp.cc

Issue 2422173003: [regexp] Work around gcc bug triggering -Werror=strict-overflow (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-regexp.cc

diff --git a/src/runtime/runtime-regexp.cc b/src/runtime/runtime-regexp.cc

index ac1369ddcc4c52a43a10b5447c3256429192fda2..7c0a7f25f1b9520c363d1fd934b6c90b27ff7281 100644

--- a/src/runtime/runtime-regexp.cc

+++ b/src/runtime/runtime-regexp.cc

@@ -1338,8 +1338,8 @@ MaybeHandle<String> StringReplaceNonGlobalRegExpWithFunction(

}

- argv[m] = handle(Smi::FromInt(index), isolate);

- argv[m + 1] = subject;

+ argv[argc - 2] = handle(Smi::FromInt(index), isolate);

+ argv[argc - 1] = subject;

Handle<Object> replacement_obj;

ASSIGN_RETURN_ON_EXCEPTION(

« no previous file with comments | « no previous file | src/vector.h » ('j') | no next file with comments »