Issue 2422143002: Do not inline object-stats functions to reduce binary size.

Issue 2422143002: Do not inline object-stats functions to reduce binary size. (Closed)

Created:
4 years, 2 months ago by Camillo Bruni

Modified:
4 years, 2 months ago

Reviewers:
Michael Lippautz, fmeawad

CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Do not inline object-stats functions to reduce binary size. BUG=chromium:645378 Committed: https://crrev.com/f8654ce9f612ff3dc57e0b2d4d27fc9ea1ee0aab Cr-Commit-Position: refs/heads/master@{#40355}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -60 lines)			Patch
M	src/counters.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/counters.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/heap/object-stats.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/heap/object-stats.cc	View		3 chunks	+63 lines, -55 lines	0 comments	Download

Total messages: 10 (4 generated)

Camillo Bruni

PTAL this saves around 80KB in the binary. I still need to figure out a ...

4 years, 2 months ago (2016-10-17 08:17:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422143002/20001

4 years, 2 months ago (2016-10-17 10:41:28 UTC) #5

commit-bot: I haz the power

Patchset 2 (id:??) landed as https://crrev.com/f8654ce9f612ff3dc57e0b2d4d27fc9ea1ee0aab Cr-Commit-Position: refs/heads/master@{#40355}

4 years, 2 months ago (2016-10-17 11:10:19 UTC) #8

Message was sent while issue was closed.

lgtm