Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2420)

Unified Diff: src/heap/object-stats.h

Issue 2422143002: Do not inline object-stats functions to reduce binary size. (Closed)
Patch Set: remove debugging code Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/counters.cc ('k') | src/heap/object-stats.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/object-stats.h
diff --git a/src/heap/object-stats.h b/src/heap/object-stats.h
index 6c35425bfe11b7eaeb723c7408124887bca1ffcc..7d0cfb5a691b275e40d7372016492c4766725d91 100644
--- a/src/heap/object-stats.h
+++ b/src/heap/object-stats.h
@@ -100,6 +100,14 @@ class ObjectStats {
static const int kLastBucket = 1 << kLastBucketShift;
static const int kNumberOfBuckets = kLastBucketShift - kFirstBucketShift + 1;
+ void PrintKeyAndId(const char* key, int gc_count);
+ // The following functions are excluded from inline to reduce the overall
+ // binary size of VB. On x64 this save around 80KB.
+ V8_NOINLINE void PrintInstanceTypeJSON(const char* key, int gc_count,
+ const char* name, int index);
+ V8_NOINLINE void DumpInstanceTypeData(std::stringstream& stream,
+ const char* name, int index);
+
int HistogramIndexFromSize(size_t size) {
if (size == 0) return 0;
int idx = static_cast<int>(base::ieee754::log2(static_cast<double>(size))) -
« no previous file with comments | « src/counters.cc ('k') | src/heap/object-stats.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698