Audit use of updateStyleAndLayoutIgnorePendingStylesheets in EditingStyle::removeStyleFromRulesAndC…

third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009, 2010, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 588 matching lines @@
       // If Mail wraps the fragment with a Paste as Quotation blockquote, or if
       // you're pasting into a quoted region, styles from blockquoteNode are
       // allowed to override those from the source document, see
       // <rdar://problem/4930986> and <rdar://problem/5089327>.
       HTMLQuoteElement* blockquoteElement =
           !context || isMailPasteAsQuotationHTMLBlockQuoteElement(context)
               ? toHTMLQuoteElement(context)
               : toHTMLQuoteElement(enclosingNodeOfType(
                     Position::firstPositionInNode(context),
                     isMailHTMLBlockquoteElement, CanCrossEditingBoundary));
+
+      // EditingStyle::removeStyleFromRulesAndContext() uses StyleResolver,
+      // which requires clean style.
+      document().updateStyleAndLayoutIgnorePendingStylesheets();

[yosin_UTC9, 2016/10/17 09:45:18]

Should we call Document::updateStyle() instead of
updateStyleAndLayoutIgnorePendingStyleSheets() since a comment above says it for
StyleResolver.

[Xiaocheng, 2016/10/17 10:07:27]

Document::updateStyle is private...

[yosin_UTC9, 2016/10/18 01:40:19]

Could you leave TODO comment that we need to update only style w/ ignoring
pending style sheets?

It seems current implementation of Document::updateStyle() isn't ready for
calling out side Document::updateStyleAndLayout().
We need to do following before calling updateStyle():
  DocumentAnimations::updateAnimationTimingIfNeeded(*this);
  evaluateMediaQueryListIfNeeded();
  updateUseShadowTreesIfNeeded();
  updateDistribution();
  updateStyleInvalidationIfNeeded();

We might want to have updateLifcycleToStyleClean() similar to
FrameView::updateLifecylceToLayoutClean() in Document.

+
       if (blockquoteElement)
         newInlineStyle->removeStyleFromRulesAndContext(
             element, document().documentElement());
 
       newInlineStyle->removeStyleFromRulesAndContext(element, context);
     }
 
     if (!inlineStyle || newInlineStyle->isEmpty()) {
       if (isStyleSpanOrSpanWithOnlyStyleAttribute(element) ||
           isEmptyFontTag(element, AllowNonEmptyStyleAttribute)) {
@@ skipping 1463 matching lines @@
   visitor->trace(m_startOfInsertedContent);
   visitor->trace(m_endOfInsertedContent);
   visitor->trace(m_insertionStyle);
   visitor->trace(m_documentFragment);
   visitor->trace(m_startOfInsertedRange);
   visitor->trace(m_endOfInsertedRange);
   CompositeEditCommand::trace(visitor);
 }
 
 }  // namespace blink