Adding sampling support to installer crash reporter client.

chrome/installer/setup/installer_crash_reporter_client.cc

Index: chrome/installer/setup/installer_crash_reporter_client.cc
diff --git a/chrome/installer/setup/installer_crash_reporter_client.cc b/chrome/installer/setup/installer_crash_reporter_client.cc
index 3d9cd9a5266834244234bf09094a31316ab64d10..a716e06f916195f0a8573c893eef2c908240e290 100644
--- a/chrome/installer/setup/installer_crash_reporter_client.cc
+++ b/chrome/installer/setup/installer_crash_reporter_client.cc
@@ -14,6 +14,7 @@
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_version.h"
 #include "chrome/common/env_vars.h"
+#include "chrome/install_static/install_util.h"
 #include "chrome/installer/setup/installer_crash_reporting.h"
 #include "chrome/installer/util/google_update_settings.h"
 
@@ -123,6 +124,10 @@ bool InstallerCrashReporterClient::GetCollectStatsConsent() {
 #endif
 }
 
+bool InstallerCrashReporterClient::GetCollectStatsInSample() {
+  return install_static::GetCollectStatsInSample();

[grt (UTC plus 2), 2016/10/24 09:34:33]

it looks like install_static::GetCollectStatsInSample uses
install_static::IsSxSChrome, which doesn't seem to do the right thing when
called from the context of setup.exe. i fear that you'll need to instead
duplicate the code in install_static, but using regular Chrome-isms. something
like:

{
  // TODO(grt): remove duplication of code.
  BrowserDistribution* dist = BrowserDistribution::GetDistribution();
  base::win::RegKey key(HKEY_CURRENT_USER, dist->GetRegistryPath().c_str(),
KEY_QUERY_VALUE | KEY_WOW64_32KEY);
  if (!key.Valid())
    return true;
  DWORD out_value = 0;
  if (key.ReadValueDW(kRegValueChromeStatsSample, &out_value) != ERROR_SUCCESS)
    return true;
  return out_value == 1;
}

(i have a change out for review that will allow this to use install_static)

[jwd, 2016/10/24 21:28:52]

Done.

+}
+
 bool InstallerCrashReporterClient::ReportingIsEnforcedByPolicy(bool* enabled) {
   // From the generated policy/policy/policy_constants.cc:
 #if defined(GOOGLE_CHROME_BUILD)