Adding sampling support to installer crash reporter client.

chrome/installer/setup/installer_crash_reporter_client.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/setup/installer_crash_reporter_client.h"
 
 #include "base/debug/crash_logging.h"
 #include "base/environment.h"
 #include "base/file_version_info.h"
 #include "base/files/file_path.h"
 #include "base/path_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/registry.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_version.h"
 #include "chrome/common/env_vars.h"
+#include "chrome/install_static/install_util.h"
 #include "chrome/installer/setup/installer_crash_reporting.h"
 #include "chrome/installer/util/google_update_settings.h"
 
 InstallerCrashReporterClient::InstallerCrashReporterClient(
     bool is_per_user_install)
     : is_per_user_install_(is_per_user_install) {
 }
 
 InstallerCrashReporterClient::~InstallerCrashReporterClient() = default;
 
@@ skipping 89 matching lines @@
 
 bool InstallerCrashReporterClient::GetCollectStatsConsent() {
 #if defined(GOOGLE_CHROME_BUILD)
   return GoogleUpdateSettings::GetCollectStatsConsentAtLevel(
       !is_per_user_install_);
 #else
   return false;
 #endif
 }
 
+bool InstallerCrashReporterClient::GetCollectStatsInSample() {
+  return install_static::GetCollectStatsInSample();

[grt (UTC plus 2), 2016/10/24 09:34:33]

it looks like install_static::GetCollectStatsInSample uses
install_static::IsSxSChrome, which doesn't seem to do the right thing when
called from the context of setup.exe. i fear that you'll need to instead
duplicate the code in install_static, but using regular Chrome-isms. something
like:

{
  // TODO(grt): remove duplication of code.
  BrowserDistribution* dist = BrowserDistribution::GetDistribution();
  base::win::RegKey key(HKEY_CURRENT_USER, dist->GetRegistryPath().c_str(),
KEY_QUERY_VALUE | KEY_WOW64_32KEY);
  if (!key.Valid())
    return true;
  DWORD out_value = 0;
  if (key.ReadValueDW(kRegValueChromeStatsSample, &out_value) != ERROR_SUCCESS)
    return true;
  return out_value == 1;
}

(i have a change out for review that will allow this to use install_static)

[jwd, 2016/10/24 21:28:52]

Done.

+}
+
 bool InstallerCrashReporterClient::ReportingIsEnforcedByPolicy(bool* enabled) {
   // From the generated policy/policy/policy_constants.cc:
 #if defined(GOOGLE_CHROME_BUILD)
   static const wchar_t kRegistryChromePolicyKey[] =
       L"SOFTWARE\\Policies\\Google\\Chrome";
 #else
   static const wchar_t kRegistryChromePolicyKey[] =
       L"SOFTWARE\\Policies\\Chromium";
 #endif
   static const wchar_t kMetricsReportingEnabled[] = L"MetricsReportingEnabled";
@@ skipping 16 matching lines @@
     }
   }
 
   return false;
 }
 
 bool InstallerCrashReporterClient::EnableBreakpadForProcess(
     const std::string& process_type) {
   return true;
 }