Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2422103003: Separate method for calculating logical height based on CSS properties. (Closed)

Created:
4 years, 2 months ago by mstensho (USE GERRIT)
Modified:
4 years, 2 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate method for calculating logical height based on CSS properties. Move it out of LayoutTable::layout(), since that method is more than crowded enough as it is. Had to make convertStyleLogicalHeightToComputedHeight() a const method, since I decided to make the new method const. Constified convertStyleLogicalWidthToComputedWidth() as well, for the sake of consistency. Committed: https://crrev.com/10041638092c86dd7c5bcc37ba71ed3f30f0e306 Cr-Commit-Position: refs/heads/master@{#425757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -32 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTable.h View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 4 chunks +35 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 2 months ago (2016-10-17 08:01:38 UTC) #2
eae
Nice cleanup! LGTM
4 years, 2 months ago (2016-10-17 16:53:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422103003/1
4 years, 2 months ago (2016-10-17 17:04:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 19:53:23 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 19:57:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10041638092c86dd7c5bcc37ba71ed3f30f0e306
Cr-Commit-Position: refs/heads/master@{#425757}

Powered by Google App Engine
This is Rietveld 408576698