Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTable.h

Issue 2422103003: Separate method for calculating logical height based on CSS properties. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTable.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2010 Apple Inc. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2010 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
462 462
463 ColAndColGroup slowColElementAtAbsoluteColumn(unsigned col) const; 463 ColAndColGroup slowColElementAtAbsoluteColumn(unsigned col) const;
464 464
465 void updateColumnCache() const; 465 void updateColumnCache() const;
466 void invalidateCachedColumns(); 466 void invalidateCachedColumns();
467 467
468 void updateLogicalWidth() override; 468 void updateLogicalWidth() override;
469 469
470 LayoutUnit convertStyleLogicalWidthToComputedWidth( 470 LayoutUnit convertStyleLogicalWidthToComputedWidth(
471 const Length& styleLogicalWidth, 471 const Length& styleLogicalWidth,
472 LayoutUnit availableWidth); 472 LayoutUnit availableWidth) const;
473 LayoutUnit convertStyleLogicalHeightToComputedHeight( 473 LayoutUnit convertStyleLogicalHeightToComputedHeight(
474 const Length& styleLogicalHeight); 474 const Length& styleLogicalHeight) const;
475 475
476 LayoutRect overflowClipRect( 476 LayoutRect overflowClipRect(
477 const LayoutPoint& location, 477 const LayoutPoint& location,
478 OverlayScrollbarClipBehavior = IgnoreOverlayScrollbarSize) const override; 478 OverlayScrollbarClipBehavior = IgnoreOverlayScrollbarSize) const override;
479 479
480 void addOverflowFromChildren() override; 480 void addOverflowFromChildren() override;
481 481
482 void recalcSections() const; 482 void recalcSections() const;
483 void layoutCaption(LayoutTableCaption&, SubtreeLayoutScope&); 483 void layoutCaption(LayoutTableCaption&, SubtreeLayoutScope&);
484 void layoutSection(LayoutTableSection&, 484 void layoutSection(LayoutTableSection&,
485 SubtreeLayoutScope&, 485 SubtreeLayoutScope&,
486 LayoutUnit logicalLeft); 486 LayoutUnit logicalLeft);
487 487
488 // Return the logical height based on the height, min-height and max-height
489 // properties from CSS. Will return 0 if auto.
490 LayoutUnit logicalHeightFromStyle() const;
491
488 void distributeExtraLogicalHeight(int extraLogicalHeight); 492 void distributeExtraLogicalHeight(int extraLogicalHeight);
489 493
490 void recalcCollapsedBordersIfNeeded(); 494 void recalcCollapsedBordersIfNeeded();
491 495
492 // TODO(layout-dev): All mutables in this class are lazily updated by 496 // TODO(layout-dev): All mutables in this class are lazily updated by
493 // recalcSections() which is called by various getter methods (e.g. 497 // recalcSections() which is called by various getter methods (e.g.
494 // borderBefore(), borderAfter()). 498 // borderBefore(), borderAfter()).
495 // They allow dirty layout even after DocumentLifecycle::LayoutClean which 499 // They allow dirty layout even after DocumentLifecycle::LayoutClean which
496 // seems not proper. crbug.com/538236. 500 // seems not proper. crbug.com/538236.
497 501
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 if (m_firstBody) 573 if (m_firstBody)
570 return m_firstBody; 574 return m_firstBody;
571 return m_foot; 575 return m_foot;
572 } 576 }
573 577
574 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTable, isTable()); 578 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTable, isTable());
575 579
576 } // namespace blink 580 } // namespace blink
577 581
578 #endif // LayoutTable_h 582 #endif // LayoutTable_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTable.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698