Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2422083002: Remove usage of FOR_EACH_OBSERVER macro in components/policy (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in components/policy Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/dc7ddf145e6c0b3c77c54744d7f68216264d7c0e Cr-Commit-Position: refs/heads/master@{#425633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -35 lines) Patch
M components/policy/core/browser/configuration_policy_pref_store.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_client.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_core.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_store.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M components/policy/core/common/configuration_policy_provider.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/policy/core/common/policy_service_impl.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M components/policy/core/common/remote_commands/remote_commands_queue.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/policy/core/common/schema_registry.cc View 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-17 01:10:56 UTC) #4
pastarmovj
lgtm
4 years, 2 months ago (2016-10-17 08:10:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422083002/1
4 years, 2 months ago (2016-10-17 08:19:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 08:26:11 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 08:30:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc7ddf145e6c0b3c77c54744d7f68216264d7c0e
Cr-Commit-Position: refs/heads/master@{#425633}

Powered by Google App Engine
This is Rietveld 408576698