Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: components/policy/core/common/cloud/cloud_policy_core.cc

Issue 2422083002: Remove usage of FOR_EACH_OBSERVER macro in components/policy (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/cloud/cloud_policy_core.cc
diff --git a/components/policy/core/common/cloud/cloud_policy_core.cc b/components/policy/core/common/cloud/cloud_policy_core.cc
index a1085740f08f46657d7ff65967155e28b79ab81a..d6f75037ad94910c823b480bbe6e6af2d3064a09 100644
--- a/components/policy/core/common/cloud/cloud_policy_core.cc
+++ b/components/policy/core/common/cloud/cloud_policy_core.cc
@@ -43,12 +43,14 @@ void CloudPolicyCore::Connect(std::unique_ptr<CloudPolicyClient> client) {
client_ = std::move(client);
service_.reset(new CloudPolicyService(policy_type_, settings_entity_id_,
client_.get(), store_));
- FOR_EACH_OBSERVER(Observer, observers_, OnCoreConnected(this));
+ for (auto& observer : observers_)
+ observer.OnCoreConnected(this);
}
void CloudPolicyCore::Disconnect() {
if (client_)
- FOR_EACH_OBSERVER(Observer, observers_, OnCoreDisconnecting(this));
+ for (auto& observer : observers_)
+ observer.OnCoreDisconnecting(this);
refresh_delay_.reset();
refresh_scheduler_.reset();
remote_commands_service_.reset();
@@ -67,7 +69,8 @@ void CloudPolicyCore::StartRemoteCommandsService(
// Do an initial remote commands fetch immediately.
remote_commands_service_->FetchRemoteCommands();
- FOR_EACH_OBSERVER(Observer, observers_, OnRemoteCommandsServiceStarted(this));
+ for (auto& observer : observers_)
+ observer.OnRemoteCommandsServiceStarted(this);
}
void CloudPolicyCore::RefreshSoon() {
@@ -80,7 +83,8 @@ void CloudPolicyCore::StartRefreshScheduler() {
refresh_scheduler_.reset(
new CloudPolicyRefreshScheduler(client_.get(), store_, task_runner_));
UpdateRefreshDelayFromPref();
- FOR_EACH_OBSERVER(Observer, observers_, OnRefreshSchedulerStarted(this));
+ for (auto& observer : observers_)
+ observer.OnRefreshSchedulerStarted(this);
}
}

Powered by Google App Engine
This is Rietveld 408576698