Enable Device Motion API on all platforms by default.

Enable Device Motion API on all platforms by default.

After this change the JavaScript expression 'window.DeviceMotionEvent'
will start evaluating to true on all platforms.

For Android, Windows and Mac devices with accelerometer and
gyroscope sensors events will start being delivered.
For devices without such sensors, and for other platforms
(e.g. Chrome OS, Linux) which do not have corresponding sensor
data fetcher implementations, we'll deliver a one-shot event
with all properties set the NULL, per the specification.

This patch also removes the obsolete 'enable-device-motion'
flag, instead the 'disable-device-motion' flag is available.

BUG=135804
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224164

[Peter Beverloo, 2013-09-18 15:17:39]

To confirm, per this change the JavaScript expression:

'ondevicemotion' in window

..will start evaluating to true on all platforms.

For Android, Windows and Mac devices with accelerometer sensors events will
start being delivered.  For devices without such a sensor, and for other
platforms (Chrome OS, Linux) which do not have a data fetcher implementation,
we'll deliver a one-shot event with all properties set the NULL, per the
specification.

Is this correct?

It'd be great if you could include this information in the description of this
change, because it gives reviewers (and people reading the commits)
significantly more context.

https://codereview.chromium.org/24220002/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/24220002/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_process_host_impl.cc:1017:
switches::kEnableDeviceMotion,
Can we remove this flag altogether now that the feature will be enabled by
default, and only keep kDisableDeviceMotion?

[timvolodine, 2013-09-18 16:27:37]

https://codereview.chromium.org/24220002/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/24220002/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_process_host_impl.cc:1017:
switches::kEnableDeviceMotion,
On 2013/09/18 15:17:39, Peter Beverloo wrote:
> Can we remove this flag altogether now that the feature will be enabled by
> default, and only keep kDisableDeviceMotion?

Done.

[timvolodine, 2013-09-18 16:28:20]

On 2013/09/18 15:17:39, Peter Beverloo wrote:
> To confirm, per this change the JavaScript expression:
> 
> 'ondevicemotion' in window
> 
> ..will start evaluating to true on all platforms.
> 
> For Android, Windows and Mac devices with accelerometer sensors events will
> start being delivered.  For devices without such a sensor, and for other
> platforms (Chrome OS, Linux) which do not have a data fetcher implementation,
> we'll deliver a one-shot event with all properties set the NULL, per the
> specification.
> 
> Is this correct?
> 
> It'd be great if you could include this information in the description of this
> change, because it gives reviewers (and people reading the commits)
> significantly more context.
> 

that is correct, I've added this to the patch description. thanks!

[Peter Beverloo, 2013-09-18 17:43:11]

On 2013/09/18 16:28:20, timvolodine wrote:
> On 2013/09/18 15:17:39, Peter Beverloo wrote:
> > To confirm, per this change the JavaScript expression:
> > 
> > 'ondevicemotion' in window
> > 
> > ..will start evaluating to true on all platforms.
> > 
> > For Android, Windows and Mac devices with accelerometer sensors events will
> > start being delivered.  For devices without such a sensor, and for other
> > platforms (Chrome OS, Linux) which do not have a data fetcher
implementation,
> > we'll deliver a one-shot event with all properties set the NULL, per the
> > specification.
> > 
> > Is this correct?
> > 
> > It'd be great if you could include this information in the description of
this
> > change, because it gives reviewers (and people reading the commits)
> > significantly more context.
> > 
> 
> that is correct, I've added this to the patch description. thanks!

cool, thanks! lgtm

Don't forget to update the DeviceMotion status in RuntimeEnabledFeatures.in.  It
may actually be better to do that before this change, to make sure that there's
not a brief period of time in which the feature isn't enabled.

[timvolodine, 2013-09-18 17:56:26]

On 2013/09/18 17:43:11, Peter Beverloo wrote:
> On 2013/09/18 16:28:20, timvolodine wrote:
> > On 2013/09/18 15:17:39, Peter Beverloo wrote:
> > > To confirm, per this change the JavaScript expression:
> > > 
> > > 'ondevicemotion' in window
> > > 
> > > ..will start evaluating to true on all platforms.
> > > 
> > > For Android, Windows and Mac devices with accelerometer sensors events
will
> > > start being delivered.  For devices without such a sensor, and for other
> > > platforms (Chrome OS, Linux) which do not have a data fetcher
> implementation,
> > > we'll deliver a one-shot event with all properties set the NULL, per the
> > > specification.
> > > 
> > > Is this correct?
> > > 
> > > It'd be great if you could include this information in the description of
> this
> > > change, because it gives reviewers (and people reading the commits)
> > > significantly more context.
> > > 
> > 
> > that is correct, I've added this to the patch description. thanks!
> 
> cool, thanks! lgtm
> 
> Don't forget to update the DeviceMotion status in RuntimeEnabledFeatures.in. 
It
> may actually be better to do that before this change, to make sure that
there's
> not a brief period of time in which the feature isn't enabled.

ok that's for pointing this out, will land the corresponding Blink patch first:
https://codereview.chromium.org/23578042/.

[timvolodine, 2013-09-18 17:56:43]

piman@chromium.org: Please review changes in

[piman, 2013-09-18 20:43:41]

LGTM

[commit-bot: I haz the power, 2013-09-19 15:28:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/24220002/9001

[commit-bot: I haz the power, 2013-09-19 18:07:59]

Change committed as 224164