Chromium Code Reviews| Index: components/app_modal/javascript_dialog_manager.h |
| diff --git a/components/app_modal/javascript_dialog_manager.h b/components/app_modal/javascript_dialog_manager.h |
| index 9e9dfeb63b7df1f85d134892d9bbe8349182ad19..30181426fe81b6620857fb6bae4475ba4b88d423 100644 |
| --- a/components/app_modal/javascript_dialog_manager.h |
| +++ b/components/app_modal/javascript_dialog_manager.h |
| @@ -37,11 +37,9 @@ class JavaScriptDialogManager : public content::JavaScriptDialogManager { |
| void SetExtensionsClient( |
| std::unique_ptr<JavaScriptDialogExtensionsClient> extensions_client); |
| - private: |
| - friend struct base::DefaultSingletonTraits<JavaScriptDialogManager>; |
| - |
| - JavaScriptDialogManager(); |
| - ~JavaScriptDialogManager() override; |
| + // Gets the title for a dialog. |
| + base::string16 GetTitle(content::WebContents* web_contents, |
| + const GURL& origin_url); |
|
Peter Kasting
2016/10/17 20:16:05
Nit: Move definition order in .cc to match
Avi (use Gerrit)
2016/10/18 02:46:42
Done.
|
| // JavaScriptDialogManager: |
| void RunJavaScriptDialog(content::WebContents* web_contents, |
| @@ -61,9 +59,11 @@ class JavaScriptDialogManager : public content::JavaScriptDialogManager { |
| bool suppress_callbacks, |
| bool reset_state) override; |
| - base::string16 GetTitle(content::WebContents* web_contents, |
| - const GURL& origin_url, |
| - bool is_alert); |
| + private: |
| + friend struct base::DefaultSingletonTraits<JavaScriptDialogManager>; |
| + |
| + JavaScriptDialogManager(); |
| + ~JavaScriptDialogManager() override; |
| // Wrapper around OnDialogClosed; logs UMA stats before continuing on. |
| void OnBeforeUnloadDialogClosed(content::WebContents* web_contents, |