Make JavaScript dialogs auto-dismiss on tab switch.

components/app_modal/javascript_dialog_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_APP_MODAL_JAVASCRIPT_DIALOG_MANAGER_H_
 #define COMPONENTS_APP_MODAL_JAVASCRIPT_DIALOG_MANAGER_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 19 matching lines @@
   // dialog window instances.
   void SetNativeDialogFactory(
       std::unique_ptr<JavaScriptNativeDialogFactory> factory);
 
   // JavaScript dialogs may be opened by an extensions/app, thus they need
   // access to extensions functionality. This sets a client interface to
   // access //extensions.
   void SetExtensionsClient(
       std::unique_ptr<JavaScriptDialogExtensionsClient> extensions_client);
 
- private:
-  friend struct base::DefaultSingletonTraits<JavaScriptDialogManager>;
-
-  JavaScriptDialogManager();
-  ~JavaScriptDialogManager() override;
+  // Gets the title for a dialog.
+  base::string16 GetTitle(content::WebContents* web_contents,
+                          const GURL& origin_url);

[Peter Kasting, 2016/10/17 20:16:05]

Nit: Move definition order in .cc to match

[Avi (use Gerrit), 2016/10/18 02:46:42]

Done.

 
   // JavaScriptDialogManager:
   void RunJavaScriptDialog(content::WebContents* web_contents,
                            const GURL& origin_url,
                            content::JavaScriptMessageType message_type,
                            const base::string16& message_text,
                            const base::string16& default_prompt_text,
                            const DialogClosedCallback& callback,
                            bool* did_suppress_message) override;
   void RunBeforeUnloadDialog(content::WebContents* web_contents,
                              bool is_reload,
                              const DialogClosedCallback& callback) override;
   bool HandleJavaScriptDialog(content::WebContents* web_contents,
                               bool accept,
                               const base::string16* prompt_override) override;
   void CancelDialogs(content::WebContents* web_contents,
                      bool suppress_callbacks,
                      bool reset_state) override;
 
-  base::string16 GetTitle(content::WebContents* web_contents,
-                          const GURL& origin_url,
-                          bool is_alert);
+ private:
+  friend struct base::DefaultSingletonTraits<JavaScriptDialogManager>;
+
+  JavaScriptDialogManager();
+  ~JavaScriptDialogManager() override;
 
   // Wrapper around OnDialogClosed; logs UMA stats before continuing on.
   void OnBeforeUnloadDialogClosed(content::WebContents* web_contents,
                                   DialogClosedCallback callback,
                                   bool success,
                                   const base::string16& user_input);
 
   // Wrapper around a DialogClosedCallback so that we can intercept it before
   // passing it onto the original callback.
   void OnDialogClosed(content::WebContents* web_contents,
@@ skipping 12 matching lines @@
   // dialogs. (Since Javascript dialogs are modal, this is even accurate!)
   base::TimeTicks last_close_time_;
   base::TimeTicks last_creation_time_;
 
   DISALLOW_COPY_AND_ASSIGN(JavaScriptDialogManager);
 };
 
 }  // namespace app_modal
 
 #endif  // COMPONENTS_APP_MODAL_JAVASCRIPT_DIALOG_MANAGER_H_