Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(276)

Issue 2421903004: Disable pll_loader_test on arm hardware. (Closed)

Created:
2 years, 11 months ago by bradnelson
Modified:
2 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tests/pnacl_dynamic_loading/nacl.scons View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
bradn
2 years, 11 months ago (2016-10-15 00:09:37 UTC) #2
Sean Klein
lgtm
2 years, 11 months ago (2016-10-15 00:11:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421903004/1
2 years, 11 months ago (2016-10-15 00:13:34 UTC) #5
Mark Seaborn
https://codereview.chromium.org/2421903004/diff/1/tests/pnacl_dynamic_loading/nacl.scons File tests/pnacl_dynamic_loading/nacl.scons (right): https://codereview.chromium.org/2421903004/diff/1/tests/pnacl_dynamic_loading/nacl.scons#newcode147 tests/pnacl_dynamic_loading/nacl.scons:147: on_arm_hw = not env.Bit('running_on_vm') and env.Bit('build_arm') I'm pretty sure ...
2 years, 11 months ago (2016-10-15 00:16:29 UTC) #8
bradn
ptal
2 years, 11 months ago (2016-10-15 00:19:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421903004/20001
2 years, 11 months ago (2016-10-15 00:39:40 UTC) #13
commit-bot: I haz the power
2 years, 11 months ago (2016-10-15 01:40:47 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/native_client/src/native_client/+/0ed980949...

Powered by Google App Engine
This is Rietveld 408576698