Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests/pnacl_dynamic_loading/nacl.scons

Issue 2421903004: Disable pll_loader_test on arm hardware. (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/pnacl_dynamic_loading/nacl.scons
diff --git a/tests/pnacl_dynamic_loading/nacl.scons b/tests/pnacl_dynamic_loading/nacl.scons
index d724ae96beee39c48ddd5db6b89a66fdcc70120a..6efd44fc5f0b157efcdef8e16819d0dc9ef92a14 100644
--- a/tests/pnacl_dynamic_loading/nacl.scons
+++ b/tests/pnacl_dynamic_loading/nacl.scons
@@ -143,9 +143,11 @@ node = env.CommandSelLdrTestNacl(
# Add '-a' to enable filesystem access for opening DSOs.
sel_ldr_flags=['-a'],
extra_deps=[test_pll_a, test_pll_b, test_pll_tls, test_pll_tls_dependency])
+# TODO: Fix on arm panda hardware.
+on_arm_hw = not env.UsingEmulator() and env.Bit('build_arm')
env.AddNodeToTestSuite(
node, ['small_tests', 'toolchain_tests'],
- 'run_pll_loader_test', is_broken=is_broken)
+ 'run_pll_loader_test', is_broken=is_broken or on_arm_hw)
pll_libc_nonfinal = env.Command(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698