Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2421803002: [builtins] Migrate Object.setPrototypeOf to C++. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate Object.setPrototypeOf to C++. This calls into C++ anyways, so no need to add the JavaScript wrapper around it. R=yangguo@chromium.org BUG=v8:5049 Committed: https://crrev.com/4a88d8fb1d78c71101481e92bb3ec01b526ba97d Cr-Commit-Position: refs/heads/master@{#40293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -23 lines) Patch
M src/bootstrapper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins-object.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/js/v8natives.js View 2 chunks +0 lines, -23 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-14 07:04:36 UTC) #1
Benedikt Meurer
Hey Yang, Here's a quick one for v8natives.js (prerequisite for __proto__ migration/optimization). Please take a ...
4 years, 2 months ago (2016-10-14 07:05:18 UTC) #4
Yang
On 2016/10/14 07:05:18, Benedikt Meurer wrote: > Hey Yang, > > Here's a quick one ...
4 years, 2 months ago (2016-10-14 07:22:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421803002/1
4 years, 2 months ago (2016-10-14 07:22:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 08:10:03 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 08:10:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a88d8fb1d78c71101481e92bb3ec01b526ba97d
Cr-Commit-Position: refs/heads/master@{#40293}

Powered by Google App Engine
This is Rietveld 408576698