Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2417183002: [builtins] Also port the Object.prototype.__proto__ accessors to C++. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Also port the Object.prototype.__proto__ accessors to C++. These accessors also always call into C++ anyways, so there's no point in having the JavaScript wrappers. R=yangguo@chromium.org BUG=v8:5049, chromium:655963 Committed: https://crrev.com/ede69cfabd790fe9f171b5d1f426ea0fc55e3c98 Committed: https://crrev.com/71cb88281c7c9bd1dc390233be80a1b5040288d1 Cr-Original-Commit-Position: refs/heads/master@{#40298} Cr-Commit-Position: refs/heads/master@{#40306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -33 lines) Patch
M src/bootstrapper.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins-object.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M src/js/v8natives.js View 2 chunks +0 lines, -18 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 28 (16 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-14 07:35:49 UTC) #1
Benedikt Meurer
Hey Yang, Follow-up fix. Please take a look. Thanks, Benedikt
4 years, 2 months ago (2016-10-14 07:36:22 UTC) #4
Yang
On 2016/10/14 07:36:22, Benedikt Meurer wrote: > Hey Yang, > > Follow-up fix. > Please ...
4 years, 2 months ago (2016-10-14 07:44:11 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2421803002 Patch 1). Please resolve the dependency and ...
4 years, 2 months ago (2016-10-14 07:46:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417183002/1
4 years, 2 months ago (2016-10-14 08:34:27 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 08:36:47 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ede69cfabd790fe9f171b5d1f426ea0fc55e3c98 Cr-Commit-Position: refs/heads/master@{#40298}
4 years, 2 months ago (2016-10-14 08:36:59 UTC) #14
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2415173003/ by machenbach@chromium.org. ...
4 years, 2 months ago (2016-10-14 09:50:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417183002/1
4 years, 2 months ago (2016-10-14 11:20:09 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417183002/1
4 years, 2 months ago (2016-10-14 11:22:39 UTC) #24
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 11:24:50 UTC) #26
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 11:25:12 UTC) #28
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71cb88281c7c9bd1dc390233be80a1b5040288d1
Cr-Commit-Position: refs/heads/master@{#40306}

Powered by Google App Engine
This is Rietveld 408576698