Source/bindings/v8/V8HiddenPropertyName.h - Issue 24218002: Avoid calling v8::Isolate::GetCurrent() twice in V8HiddenPropertyName

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8HiddenPropertyName.h

Issue 24218002: Avoid calling v8::Isolate::GetCurrent() twice in V8HiddenPropertyName (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8HiddenPropertyName.h

diff --git a/Source/bindings/v8/V8HiddenPropertyName.h b/Source/bindings/v8/V8HiddenPropertyName.h

index 63b7c485ea382ba4ae68e1f76e1b3820ee440a2f..58ab5c130d621cfd65fbccc6107b7be0d53d8c2e 100644

--- a/Source/bindings/v8/V8HiddenPropertyName.h

+++ b/Source/bindings/v8/V8HiddenPropertyName.h

@@ -71,7 +71,7 @@ public:

static void setNamedHiddenReference(v8::Handle<v8::Object> parent, const char* name, v8::Handle<v8::Value> child);

private:

- static void createString(const char* key, v8::Persistent<v8::String>* handle);

+ static void createString(const char* key, v8::Persistent<v8::String>* handle, v8::Isolate*);

#define V8_DECLARE_FIELD(name) v8::Persistent<v8::String> m_##name;

V8_HIDDEN_PROPERTIES(V8_DECLARE_FIELD);

#undef V8_DECLARE_FIELD

« no previous file with comments | « no previous file | Source/bindings/v8/V8HiddenPropertyName.cpp » ('j') | no next file with comments »