Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: Source/bindings/v8/V8HiddenPropertyName.h

Issue 24218002: Avoid calling v8::Isolate::GetCurrent() twice in V8HiddenPropertyName (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/v8/V8HiddenPropertyName.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 class V8HiddenPropertyName { 64 class V8HiddenPropertyName {
65 public: 65 public:
66 V8HiddenPropertyName() { } 66 V8HiddenPropertyName() { }
67 #define V8_DECLARE_PROPERTY(name) static v8::Handle<v8::String> name(); 67 #define V8_DECLARE_PROPERTY(name) static v8::Handle<v8::String> name();
68 V8_HIDDEN_PROPERTIES(V8_DECLARE_PROPERTY); 68 V8_HIDDEN_PROPERTIES(V8_DECLARE_PROPERTY);
69 #undef V8_DECLARE_PROPERTY 69 #undef V8_DECLARE_PROPERTY
70 70
71 static void setNamedHiddenReference(v8::Handle<v8::Object> parent, const cha r* name, v8::Handle<v8::Value> child); 71 static void setNamedHiddenReference(v8::Handle<v8::Object> parent, const cha r* name, v8::Handle<v8::Value> child);
72 72
73 private: 73 private:
74 static void createString(const char* key, v8::Persistent<v8::String>* handle ); 74 static void createString(const char* key, v8::Persistent<v8::String>* handle , v8::Isolate*);
75 #define V8_DECLARE_FIELD(name) v8::Persistent<v8::String> m_##name; 75 #define V8_DECLARE_FIELD(name) v8::Persistent<v8::String> m_##name;
76 V8_HIDDEN_PROPERTIES(V8_DECLARE_FIELD); 76 V8_HIDDEN_PROPERTIES(V8_DECLARE_FIELD);
77 #undef V8_DECLARE_FIELD 77 #undef V8_DECLARE_FIELD
78 }; 78 };
79 79
80 } 80 }
81 81
82 #endif // V8HiddenPropertyName_h 82 #endif // V8HiddenPropertyName_h
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/v8/V8HiddenPropertyName.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698