Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 242173002: Make GN build work on Mac again. (Closed)

Created:
6 years, 8 months ago by brettw
Modified:
6 years, 8 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, tfarina, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Make GN build work on Mac again. This adds extension detection for lower-case ".s" assembly files (used in NSPR) in addition to the existing handling of uppercase ".S" ones. Minor fixes for build files for Mac for dependencies and files. Proper handling of USE_NSS and addition of USE_OPENSSL_CERTS that match the GYP build. R=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265064

Patch Set 1 #

Patch Set 2 : Undo mistakes #

Total comments: 2

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -17 lines) Patch
M build/config/BUILD.gn View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M build/config/crypto.gni View 1 chunk +8 lines, -0 lines 0 comments Download
M net/BUILD.gn View 1 2 3 chunks +19 lines, -10 lines 0 comments Download
M skia/skia_gn_files.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/filesystem_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/third_party/nss/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/events/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 4 chunks +12 lines, -1 line 0 comments Download
M ui/gfx/geometry/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 8 months ago (2014-04-17 23:17:08 UTC) #1
Ryan Sleevi
LGTM mod comment nit https://codereview.chromium.org/242173002/diff/20001/build/config/BUILD.gn File build/config/BUILD.gn (right): https://codereview.chromium.org/242173002/diff/20001/build/config/BUILD.gn#newcode113 build/config/BUILD.gn:113: # USE_NSS_CERTS to match OpenSSL ...
6 years, 8 months ago (2014-04-18 00:25:07 UTC) #2
brettw
6 years, 8 months ago (2014-04-21 20:55:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r265064.

Powered by Google App Engine
This is Rietveld 408576698