Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: ui/gfx/BUILD.gn

Issue 242173002: Make GN build work on Mac again. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/BUILD.gn ('k') | ui/gfx/geometry/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/BUILD.gn
diff --git a/ui/gfx/BUILD.gn b/ui/gfx/BUILD.gn
index 20997aa4968d032b9f2432924223bcf370cc4f05..783394556cca4d11fb0bb12c56048543616972b0 100644
--- a/ui/gfx/BUILD.gn
+++ b/ui/gfx/BUILD.gn
@@ -7,6 +7,16 @@ if (is_android) {
import("//build/config/android/config.gni")
}
+# Several targets want to include this header file, and some of them are
+# child dependencies of "gfx". Therefore, we separate it out here so multiple
+# targets can all have a dependency for header checking purposes without
+# creating circular dependencies.
+source_set("gfx_export") {
+ sources = [
+ "gfx_export.h",
+ ]
+}
+
component("gfx") {
sources = [
"android/device_display_info.cc",
@@ -84,7 +94,6 @@ component("gfx") {
"frame_time.h",
"gdi_util.cc",
"gdi_util.h",
- "gfx_export.h",
"gfx_paths.cc",
"gfx_paths.h",
"gpu_memory_buffer.cc",
@@ -235,6 +244,7 @@ component("gfx") {
defines = [ "GFX_IMPLEMENTATION" ]
deps = [
+ ":gfx_export",
"//base",
"//base:i18n",
"//base:base_static",
@@ -389,6 +399,7 @@ source_set("gfx_test_support") {
deps = [
"//base",
+ "//base/test:test_support",
"//skia",
"//testing/gtest",
]
« no previous file with comments | « ui/events/BUILD.gn ('k') | ui/gfx/geometry/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698