arc: bluetooth: Expose missing advertise data.

device/bluetooth/bluetooth_device.h

Index: device/bluetooth/bluetooth_device.h
diff --git a/device/bluetooth/bluetooth_device.h b/device/bluetooth/bluetooth_device.h
index 803dd8f8ef32600f8deb24f241aa066c0721a02c..96349b26beef7c729746e2adac6a7699fa51f8fb 100644
--- a/device/bluetooth/bluetooth_device.h
+++ b/device/bluetooth/bluetooth_device.h
@@ -11,6 +11,7 @@
 #include <memory>
 #include <set>
 #include <string>
+#include <unordered_map>
 #include <unordered_set>
 #include <vector>
 
@@ -319,6 +320,15 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDevice {
   const std::vector<uint8_t>* GetServiceDataForUUID(
       const BluetoothUUID& uuid) const;
 
+  // Returns advertised Manufacturer Data. Keys are 16 bits Manufacturer ID

[ortuno, 2016/10/14 00:15:10]

s/ID/IDs/

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+  // followed by its byte array value. Returns an empty map if the device
+  // does not advertise any Manufacturer Data.
+  //
+  // Note that only BlueZ support this now. This method returns an empty map

[ortuno, 2016/10/14 00:15:10]

s/support/supports/

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+  // on platform without BlueZ.

[ortuno, 2016/10/14 00:15:10]

nit: on platforms that don't use BlueZ.

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+  virtual std::unordered_map<uint16_t, std::vector<uint8_t>>

[ortuno, 2016/10/14 00:15:10]

Please match the pattern of ServiceData i.e. same set of functions,
manufacturer_data_ member in BluetoothDevice, etc. Also consider adding a
typedef for std::unordered_map<...>.

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+  GetManufacturerData() const;
+
   // The received signal strength, in dBm. This field is avaliable and valid
   // only during discovery.
   // TODO(http://crbug.com/580406): Devirtualize once BlueZ sets inquiry_rssi_.
@@ -331,6 +341,12 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDevice {
   // inquiry_tx_power_.
   virtual base::Optional<int8_t> GetInquiryTxPower() const;
 
+  // Returns Bluetooth flags in Advertise Data.

[ortuno, 2016/10/14 00:15:10]

s/Advertise/Advertising/ and also I think you can drop 'Bluetooth'. 

Could you add more detail so that we know how to implement this on other
platforms? For example: Does this reflect the latest advertising packet? What
happens if a packet stops advertising flags? Does GetFlags() still return the
last value? Does this get invalidated when we stop scanning?

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+  //
+  // Note that only BlueZ support this now. This method returns base::nullopt

[ortuno, 2016/10/14 00:15:10]

s/support/supports/

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+  // on platform without BlueZ.

[ortuno, 2016/10/14 00:15:10]

nit: on platforms that don't use BlueZ.

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+  virtual base::Optional<uint8_t> GetFlags() const;

[ortuno, 2016/10/14 00:15:10]

There are a lot of flags in Bluetooth ^.^ so you might want to call this
GetAdvertisingDataFlags()

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+
   // The ErrorCallback is used for methods that can fail in which case it
   // is called, in the success case the callback is simply not called.
   typedef base::Callback<void()> ErrorCallback;