arc: bluetooth: Expose missing advertise data.

device/bluetooth/bluetooth_device.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_H_
 #define DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <set>
 #include <string>
+#include <unordered_map>
 #include <unordered_set>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/containers/scoped_ptr_hash_map.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/optional.h"
 #include "base/strings/string16.h"
 #include "base/time/time.h"
@@ skipping 288 matching lines @@
 
   // Returns the UUIDs of services for which the device advertises Service Data.
   // Returns an empty set if the adapter is not discovering.
   UUIDSet GetServiceDataUUIDs() const;
 
   // Returns a pointer to the Service Data for Service with |uuid|. Returns
   // nullptr if |uuid| has no Service Data.
   const std::vector<uint8_t>* GetServiceDataForUUID(
       const BluetoothUUID& uuid) const;
 
+  // Returns advertised Manufacturer Data. Keys are 16 bits Manufacturer ID

[ortuno, 2016/10/14 00:15:10]

s/ID/IDs/

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+  // followed by its byte array value. Returns an empty map if the device
+  // does not advertise any Manufacturer Data.
+  //
+  // Note that only BlueZ support this now. This method returns an empty map

[ortuno, 2016/10/14 00:15:10]

s/support/supports/

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+  // on platform without BlueZ.

[ortuno, 2016/10/14 00:15:10]

nit: on platforms that don't use BlueZ.

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+  virtual std::unordered_map<uint16_t, std::vector<uint8_t>>

[ortuno, 2016/10/14 00:15:10]

Please match the pattern of ServiceData i.e. same set of functions,
manufacturer_data_ member in BluetoothDevice, etc. Also consider adding a
typedef for std::unordered_map<...>.

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+  GetManufacturerData() const;
+
   // The received signal strength, in dBm. This field is avaliable and valid
   // only during discovery.
   // TODO(http://crbug.com/580406): Devirtualize once BlueZ sets inquiry_rssi_.
   virtual base::Optional<int8_t> GetInquiryRSSI() const;
 
   // The transmitted power level. This field is avaliable only for LE devices
   // that include this field in AD. It is avaliable and valid only during
   // discovery.
   // TODO(http://crbug.com/580406): Devirtualize once BlueZ sets
   // inquiry_tx_power_.
   virtual base::Optional<int8_t> GetInquiryTxPower() const;
 
+  // Returns Bluetooth flags in Advertise Data.

[ortuno, 2016/10/14 00:15:10]

s/Advertise/Advertising/ and also I think you can drop 'Bluetooth'. 

Could you add more detail so that we know how to implement this on other
platforms? For example: Does this reflect the latest advertising packet? What
happens if a packet stops advertising flags? Does GetFlags() still return the
last value? Does this get invalidated when we stop scanning?

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+  //
+  // Note that only BlueZ support this now. This method returns base::nullopt

[ortuno, 2016/10/14 00:15:10]

s/support/supports/

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+  // on platform without BlueZ.

[ortuno, 2016/10/14 00:15:10]

nit: on platforms that don't use BlueZ.

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+  virtual base::Optional<uint8_t> GetFlags() const;

[ortuno, 2016/10/14 00:15:10]

There are a lot of flags in Bluetooth ^.^ so you might want to call this
GetAdvertisingDataFlags()

[puthik_chromium, 2016/10/17 23:30:31]

Done.

+
   // The ErrorCallback is used for methods that can fail in which case it
   // is called, in the success case the callback is simply not called.
   typedef base::Callback<void()> ErrorCallback;
 
   // The ConnectErrorCallback is used for methods that can fail with an error,
   // passed back as an error code argument to this callback.
   // In the success case this callback is not called.
   typedef base::Callback<void(enum ConnectErrorCode)> ConnectErrorCallback;
 
   typedef base::Callback<void(const ConnectionInfo&)> ConnectionInfoCallback;
@@ skipping 286 matching lines @@
 
  private:
   // Returns a localized string containing the device's bluetooth address and
   // a device type for display when |name_| is empty.
   base::string16 GetAddressWithLocalizedDeviceTypeName() const;
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_H_