Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 242163002: Adding support for PVRTC, ATC, and ETC1 textures to the command buffer (Closed)

Created:
6 years, 8 months ago by bajones
Modified:
6 years, 7 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adding support for PVRTC, ATC, and ETC1 textures to the command buffer BUG=364564 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266723

Patch Set 1 #

Total comments: 1

Patch Set 2 : Refactored tests #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -111 lines) Patch
M gpu/command_buffer/common/gles2_cmd_utils_unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 1 3 chunks +44 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 7 chunks +67 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 3 chunks +90 lines, -99 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
bajones
The other half of https://codereview.chromium.org/241163003/.
6 years, 8 months ago (2014-04-17 23:13:58 UTC) #1
Ken Russell (switch to Gerrit)
LGTM if this has been tested.
6 years, 8 months ago (2014-04-18 02:04:10 UTC) #2
bajones
On 2014/04/18 02:04:10, Ken Russell wrote: > LGTM if this has been tested. Tediously :). ...
6 years, 8 months ago (2014-04-18 03:26:59 UTC) #3
bajones
zmo@: I need to rebase this before landing, but in the meantime I'd appreciate any ...
6 years, 8 months ago (2014-04-21 21:25:15 UTC) #4
Zhenyao Mo
Otherwise, LGTM https://codereview.chromium.org/242163002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc File gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc (right): https://codereview.chromium.org/242163002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc#newcode5099 gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc:5099: TEST_F(GLES2DecoderManualInitTest, GetCompressedTextureFormatsATC) { You should add a ...
6 years, 8 months ago (2014-04-21 21:38:30 UTC) #5
bajones
The CQ bit was checked by bajones@chromium.org
6 years, 8 months ago (2014-04-25 18:46:31 UTC) #6
bajones
The CQ bit was unchecked by bajones@chromium.org
6 years, 8 months ago (2014-04-25 21:09:16 UTC) #7
bajones
The CQ bit was checked by bajones@chromium.org
6 years, 8 months ago (2014-04-25 21:09:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/242163002/20001
6 years, 8 months ago (2014-04-25 22:02:07 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 23:19:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-25 23:19:44 UTC) #11
bajones
The CQ bit was checked by bajones@chromium.org
6 years, 7 months ago (2014-04-28 17:57:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/242163002/40001
6 years, 7 months ago (2014-04-28 18:01:39 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 21:59:42 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 7 months ago (2014-04-28 21:59:43 UTC) #15
bajones
The CQ bit was checked by bajones@chromium.org
6 years, 7 months ago (2014-04-28 22:37:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/242163002/40001
6 years, 7 months ago (2014-04-28 22:39:36 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 01:04:52 UTC) #18
Message was sent while issue was closed.
Change committed as 266723

Powered by Google App Engine
This is Rietveld 408576698