Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 242162: First step in l10n for the prefs window.... (Closed)

Created:
11 years, 2 months ago by TVL
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

First step in l10n for the prefs window. - Add a toolbar instead of tabs. - Make the window change size based on the content. - Center the views to the widest of the subviews. TEST=prefs window and all of the controls in it work. BUG=20538 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28244

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+2528 lines, -2907 lines) Patch
M chrome/app/nibs/Preferences.xib View 52 chunks +2425 lines, -2900 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.h View 2 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.mm View 6 chunks +92 lines, -6 lines 4 comments Download

Messages

Total messages: 2 (0 generated)
TVL
Pink - This works, doesn't do any nice animations, etc. yet. But given what it ...
11 years, 2 months ago (2009-10-06 21:24:01 UTC) #1
pink (ping after 24hrs)
11 years, 2 months ago (2009-10-06 21:30:21 UTC) #2
lgtm with comments. I didn't bother looking at the xib.

http://codereview.chromium.org/242162/diff/1/3
File chrome/browser/cocoa/preferences_window_controller.mm (right):

http://codereview.chromium.org/242162/diff/1/3#newcode179
Line 179: // Ensure the "basics" is selected.
add a TODO here to record the selected view when closing and restore to that.
The hardcoding to basics is a bug that I keep meaning to go back and re-visit.

http://codereview.chromium.org/242162/diff/1/3#newcode198
Line 198: - (NSArray *)toolbarSelectableItemIdentifiers:(NSToolbar *)toolbar {
chrome style is NSArray*, not NSArray *

http://codereview.chromium.org/242162/diff/1/3#newcode825
Line 825: - (void)displayPreferenceView:(NSView*)prefsView {
function-level comment?

http://codereview.chromium.org/242162/diff/1/3#newcode829
Line 829: // Remove the previous view
period at end of sentence (all comments in this method).

Powered by Google App Engine
This is Rietveld 408576698