First step in l10n for the prefs window....

chrome/browser/cocoa/preferences_window_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/preferences_window_controller.h"
 
+#include <algorithm>
 #include "app/l10n_util.h"
 #include "base/mac_util.h"
 #include "base/string_util.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/browser_process.h"
 #import "chrome/browser/cocoa/clear_browsing_data_controller.h"
 #import "chrome/browser/cocoa/custom_home_pages_model.h"
 #import "chrome/browser/cocoa/keyword_editor_cocoa_controller.h"
@@ skipping 17 matching lines @@
 #include "chrome/installer/util/google_update_settings.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/locale_settings.h"
 #include "net/base/cookie_policy.h"
 
 NSString* const kUserDoneEditingPrefsNotification =
     @"kUserDoneEditingPrefsNotification";
 
 namespace {
+
 std::wstring GetNewTabUIURLString() {
   std::wstring temp = UTF8ToWide(chrome::kChromeUINewTabURL);
   return URLFixerUpper::FixupURL(temp, std::wstring());
 }
+
+// Adjusts the views origin so it will be centered if in a given width parent.
+void CenterViewForWidth(NSView* view, CGFloat width) {
+  NSRect frame = [view frame];
+  frame.origin.x = (width - NSWidth(frame)) / 2.0;
+  [view setFrame:frame];
+}
+
 }  // namespace
 
 //-------------------------------------------------------------------------
 
 @interface PreferencesWindowController(Private)
 // Callback when preferences are changed. |prefName| is the name of the
 // pref that has changed.
 - (void)prefChanged:(std::wstring*)prefName;
 // Record the user performed a certain action and save the preferences.
 - (void)recordUserAction:(const wchar_t*)action;
@@ skipping 10 matching lines @@
 - (void)setShowPageOptionsButtons:(BOOL)value;
 - (void)setPasswordManagerEnabledIndex:(NSInteger)value;
 - (void)setFormAutofillEnabledIndex:(NSInteger)value;
 - (void)setShowAlternateErrorPages:(BOOL)value;
 - (void)setUseSuggest:(BOOL)value;
 - (void)setDnsPrefetch:(BOOL)value;
 - (void)setSafeBrowsing:(BOOL)value;
 - (void)setMetricsRecording:(BOOL)value;
 - (void)setCookieBehavior:(NSInteger)value;
 - (void)setAskForSaveLocation:(BOOL)value;
+- (void)displayPreferenceView:(NSView*)subView;
 @end
 
 // A C++ class registered for changes in preferences. Bridges the
 // notification back to the PWC.
 class PrefObserverBridge : public NotificationObserver {
  public:
   PrefObserverBridge(PreferencesWindowController* controller)
       : controller_(controller) { }
   // Overridden from NotificationObserver:
   virtual void Observe(NotificationType type,
@@ skipping 51 matching lines @@
              object:searchEngineModel_.get()];
 
     // This needs to be done before awakeFromNib: because the bindings set up
     // in the nib rely on it.
     [self registerPrefObservers];
   }
   return self;
 }
 
 - (void)awakeFromNib {
-  // TODO(pinkerton): save/restore size based on prefs.
-  [[self window] center];
-
   // Put the advanced view into the scroller and scroll it to the top.
   [advancedScroller_ setDocumentView:advancedView_];
   NSInteger height = [advancedView_ bounds].size.height;
   [advancedView_ scrollPoint:NSMakePoint(0, height)];
 
-  // Ensure the "basics" tab is selected regardless of what is the selected
-  // tab in the nib.
-  [tabView_ selectFirstTabViewItem:self];
+  // Make sure the window is wide enough to fit the the widest view
+  CGFloat widest = std::max([basicsView_ frame].size.width,
+                            [personalStuffView_ frame].size.width);
+  widest = std::max(widest, [underTheHoodView_ frame].size.width);
+  NSWindow* prefsWindow = [self window];
+  NSRect frame = [prefsWindow frame];
+  frame.size.width = widest;
+  [prefsWindow setFrame:frame display:NO];
+
+  // Adjust the view origins so they show up centered.
+  CenterViewForWidth(basicsView_, widest);
+  CenterViewForWidth(personalStuffView_, widest);
+  CenterViewForWidth(underTheHoodView_, widest);
+  
+  // Ensure the "basics" is selected.

[pink (ping after 24hrs), 2009/10/06 21:30:21]

add a TODO here to record the selected view when closing and restore to that.
The hardcoding to basics is a bug that I keep meaning to go back and re-visit.

+  NSToolbarItem* firstItem = [[toolbar_ items] objectAtIndex:0];
+  [toolbar_ setSelectedItemIdentifier:[firstItem itemIdentifier]];
+  [self displayPreferenceView:basicsView_];
+
+  // TODO(pinkerton): save/restore position based on prefs.
+  [[self window] center];
 }
 
 - (void)dealloc {
   [customPagesSource_ removeObserver:self forKeyPath:@"customHomePages"];
   [[NSNotificationCenter defaultCenter] removeObserver:self];
   [self unregisterPrefObservers];
   [super dealloc];
 }
 
+// Xcode 3.1.x version of Interface Builder doesn't do a lot for editing
+// toolbars in XIB.  So the toolbar's delegate is set to the controller so it
+// can tell the toolbar what items are selectable.
+- (NSArray *)toolbarSelectableItemIdentifiers:(NSToolbar *)toolbar {

[pink (ping after 24hrs), 2009/10/06 21:30:21]

chrome style is NSArray*, not NSArray *

+  DCHECK(toolbar == toolbar_);
+  return [[toolbar_ items] valueForKey:@"itemIdentifier"];
+}
+
 // Register our interest in the preferences we're displaying so if anything
 // else in the UI changes them we will be updated.
 - (void)registerPrefObservers {
   if (!prefs_) return;
 
   // Basics panel
   prefs_->AddPrefObserver(prefs::kURLsToRestoreOnStartup, observer_.get());
   restoreOnStartup_.Init(prefs::kRestoreOnStartup, prefs_, observer_.get());
   newTabPageIsHomePage_.Init(prefs::kHomePageIsNewTabPage,
                              prefs_, observer_.get());
@@ skipping 579 matching lines @@
   NSString* path = base::SysWideToNSString(defaultDownloadLocation_.GetValue());
   [panel beginSheetForDirectory:path
                            file:nil
                           types:nil
                  modalForWindow:[self window]
                   modalDelegate:self
                  didEndSelector:@selector(downloadPathPanelDidEnd:code:context:)
                     contextInfo:NULL];
 }
 
+- (IBAction)toolbarButtonSelected:(id)sender {
+  DCHECK([sender isKindOfClass:[NSToolbarItem class]]);
+  NSToolbarItem* toolbarItem = sender;
+  
+  NSView* prefsView = NULL;
+  // Tags are set in the nib file.
+  switch ([toolbarItem tag]) {
+    case 0:  // Basics
+      prefsView = basicsView_;
+      break;
+    case 1:  // Personal Stuff
+      prefsView = personalStuffView_;
+      break;
+    case 2:  // Under the Hood
+      prefsView = underTheHoodView_;
+      break;
+    default:
+      NOTIMPLEMENTED();
+  }
+  
+  [self displayPreferenceView:prefsView];
+}
+
+- (void)displayPreferenceView:(NSView*)prefsView {

[pink (ping after 24hrs), 2009/10/06 21:30:21]

function-level comment?

+  NSWindow* prefsWindow = [self window];
+  NSView* contentView = [prefsWindow contentView];
+
+  // Remove the previous view

[pink (ping after 24hrs), 2009/10/06 21:30:21]

period at end of sentence (all comments in this method).

+  NSArray* subviews = [contentView subviews];
+  DCHECK_LE([subviews count], 1U);
+  if ([subviews count]) {
+    [[subviews objectAtIndex:0] removeFromSuperviewWithoutNeedingDisplay];
+  }
+
+  // Set the size of the window
+  NSRect windowFrame = [prefsWindow frame];
+  CGFloat titleToolbarHeight =
+      NSHeight(windowFrame) -
+      NSHeight([prefsWindow contentRectForFrameRect:windowFrame]);
+  NSRect prefsViewFrame = [prefsView frame];
+  windowFrame.size.height =
+      NSHeight(prefsViewFrame) + titleToolbarHeight;
+  DCHECK_GE(NSWidth(windowFrame), NSWidth(prefsViewFrame))
+      << "Initial width set wasn't wide enough.";
+  windowFrame.origin.y = NSMaxY([prefsWindow frame]) - NSHeight(windowFrame);
+  [prefsWindow setFrame:windowFrame display:YES];
+
+  // Add the view
+  [contentView addSubview:prefsView];
+  [prefsWindow setInitialFirstResponder:prefsView];
+}
+
 // Returns whether the alternate error page checkbox should be checked based
 // on the preference.
 - (BOOL)showAlternateErrorPages {
   return alternateErrorPages_.GetValue() ? YES : NO;
 }
 
 // Sets the backend pref for whether or not the alternate error page checkbox
 // should be displayed based on |value|.
 - (void)setShowAlternateErrorPages:(BOOL)value {
   if (value)
@@ skipping 169 matching lines @@
   [[NSNotificationCenter defaultCenter]
       postNotificationName:kUserDoneEditingPrefsNotification
                     object:self];
 }
 
 - (void)controlTextDidEndEditing:(NSNotification*)notification {
   [customPagesSource_ validateURLs];
 }
 
 @end