components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc - Issue 2421463002: FetchMore functionality backend

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2421463002: FetchMore functionality backend (Closed)

Patch Set: ID set reference, Optional callback, ... (2466863003 comments). Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h ('k') | components/ntp_snippets/remote/ntp_snippets_fetcher.h » ('j') | components/ntp_snippets/remote/ntp_snippets_fetcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

index f1f30982be07637a35f3f0591c9538c9f48bf29f..2e5163e983e829460614448499a3d49d0178a6d2 100644

--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

@@ -91,6 +91,13 @@ void PhysicalWebPageSuggestionsProvider::FetchSuggestionImage(

FROM_HERE, base::Bind(callback, gfx::Image()));

}

+void PhysicalWebPageSuggestionsProvider::Fetch(

+ const Category& category,

+ const std::set<std::string>& known_suggestion_ids,

+ FetchingCallback callback) {

+ NOTREACHED();

tschumann 2016/11/03 09:20:57 we should still call the passed-in callback. (also

void PhysicalWebPageSuggestionsProvider::ClearHistory(

base::Time begin,

base::Time end,