Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2421463002: FetchMore functionality backend (Closed)
Patch Set: ID set reference, Optional callback, ... (2466863003 comments). Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/physical_web_pages/physical_web_page_suggestio ns_provider.h" 5 #include "components/ntp_snippets/physical_web_pages/physical_web_page_suggestio ns_provider.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 } 84 }
85 85
86 void PhysicalWebPageSuggestionsProvider::FetchSuggestionImage( 86 void PhysicalWebPageSuggestionsProvider::FetchSuggestionImage(
87 const ContentSuggestion::ID& suggestion_id, 87 const ContentSuggestion::ID& suggestion_id,
88 const ImageFetchedCallback& callback) { 88 const ImageFetchedCallback& callback) {
89 // TODO(vitaliii): Implement. 89 // TODO(vitaliii): Implement.
90 base::ThreadTaskRunnerHandle::Get()->PostTask( 90 base::ThreadTaskRunnerHandle::Get()->PostTask(
91 FROM_HERE, base::Bind(callback, gfx::Image())); 91 FROM_HERE, base::Bind(callback, gfx::Image()));
92 } 92 }
93 93
94 void PhysicalWebPageSuggestionsProvider::Fetch(
95 const Category& category,
96 const std::set<std::string>& known_suggestion_ids,
97 FetchingCallback callback) {
98 NOTREACHED();
tschumann 2016/11/03 09:20:57 we should still call the passed-in callback. (also
99 }
100
94 void PhysicalWebPageSuggestionsProvider::ClearHistory( 101 void PhysicalWebPageSuggestionsProvider::ClearHistory(
95 base::Time begin, 102 base::Time begin,
96 base::Time end, 103 base::Time end,
97 const base::Callback<bool(const GURL& url)>& filter) { 104 const base::Callback<bool(const GURL& url)>& filter) {
98 ClearDismissedSuggestionsForDebugging(provided_category_); 105 ClearDismissedSuggestionsForDebugging(provided_category_);
99 } 106 }
100 107
101 void PhysicalWebPageSuggestionsProvider::ClearCachedSuggestions( 108 void PhysicalWebPageSuggestionsProvider::ClearCachedSuggestions(
102 Category category) { 109 Category category) {
103 // Ignored 110 // Ignored
(...skipping 16 matching lines...) Expand all
120 127
121 // Updates the |category_status_| and notifies the |observer_|, if necessary. 128 // Updates the |category_status_| and notifies the |observer_|, if necessary.
122 void PhysicalWebPageSuggestionsProvider::NotifyStatusChanged( 129 void PhysicalWebPageSuggestionsProvider::NotifyStatusChanged(
123 CategoryStatus new_status) { 130 CategoryStatus new_status) {
124 if (category_status_ == new_status) return; 131 if (category_status_ == new_status) return;
125 category_status_ = new_status; 132 category_status_ = new_status;
126 observer()->OnCategoryStatusChanged(this, provided_category_, new_status); 133 observer()->OnCategoryStatusChanged(this, provided_category_, new_status);
127 } 134 }
128 135
129 } // namespace ntp_snippets 136 } // namespace ntp_snippets
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698