Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2421453002: [wasm] Implement {Compile,Runtime}Error; fix traps from start function (Closed)

Created:
4 years, 2 months ago by rossberg
Modified:
4 years, 2 months ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Implement {Compile,Runtime}Error; fix traps from start function R=ahaas@chromium.org, titzer@chromium.org BUG=v8:5507 Committed: https://crrev.com/fb5b2f524141bbc9a823808f8175b6d5ffa69ea8 Cr-Commit-Position: refs/heads/master@{#40280}

Patch Set 1 #

Patch Set 2 : Oops, forgot to git-add test file #

Patch Set 3 : Rebase #

Patch Set 4 : Git cl format nonsense #

Patch Set 5 : Rebase again #

Patch Set 6 : Fix merge artefact #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -55 lines) Patch
M src/bootstrapper.cc View 1 2 3 4 2 chunks +10 lines, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/contexts.h View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M src/factory.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/factory.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap-symbols.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-js.cc View 1 2 3 7 chunks +19 lines, -7 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 2 3 4 5 9 chunks +22 lines, -20 lines 0 comments Download
M src/wasm/wasm-result.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/wasm/wasm-result.cc View 1 chunk +14 lines, -7 lines 0 comments Download
M test/common/wasm/wasm-module-runner.cc View 1 2 9 chunks +13 lines, -12 lines 0 comments Download
A test/mjsunit/wasm/errors.js View 1 1 chunk +134 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/table.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 6 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 34 (18 generated)
rossberg
4 years, 2 months ago (2016-10-13 11:41:48 UTC) #1
titzer
On 2016/10/13 11:41:48, rossberg wrote: lgtm
4 years, 2 months ago (2016-10-13 11:45:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421453002/1
4 years, 2 months ago (2016-10-13 11:57:37 UTC) #5
rossberg
Oops, forgot to git-add test file, PTAL.
4 years, 2 months ago (2016-10-13 12:03:35 UTC) #7
titzer
lgtm
4 years, 2 months ago (2016-10-13 12:04:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421453002/20001
4 years, 2 months ago (2016-10-13 12:07:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/10719)
4 years, 2 months ago (2016-10-13 12:10:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421453002/40001
4 years, 2 months ago (2016-10-13 12:22:38 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26378)
4 years, 2 months ago (2016-10-13 12:28:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421453002/60001
4 years, 2 months ago (2016-10-13 13:53:58 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/14526)
4 years, 2 months ago (2016-10-13 14:20:02 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421453002/80001
4 years, 2 months ago (2016-10-13 14:23:53 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/10760)
4 years, 2 months ago (2016-10-13 14:29:42 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421453002/100001
4 years, 2 months ago (2016-10-13 14:51:30 UTC) #30
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 2 months ago (2016-10-13 16:17:49 UTC) #32
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 16:18:19 UTC) #34
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/fb5b2f524141bbc9a823808f8175b6d5ffa69ea8
Cr-Commit-Position: refs/heads/master@{#40280}

Powered by Google App Engine
This is Rietveld 408576698